Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/full-codegen/x87/full-codegen-x87.cc

Issue 1673613002: Revert of X87: Type Feedback Vector lives in the closure. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/x87/builtins-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1118 matching lines...) Expand 10 before | Expand all | Expand 10 after
1129 1129
1130 1130
1131 void FullCodeGenerator::EmitNewClosure(Handle<SharedFunctionInfo> info, 1131 void FullCodeGenerator::EmitNewClosure(Handle<SharedFunctionInfo> info,
1132 bool pretenure) { 1132 bool pretenure) {
1133 // Use the fast case closure allocation code that allocates in new 1133 // Use the fast case closure allocation code that allocates in new
1134 // space for nested functions that don't need literals cloning. If 1134 // space for nested functions that don't need literals cloning. If
1135 // we're running with the --always-opt or the --prepare-always-opt 1135 // we're running with the --always-opt or the --prepare-always-opt
1136 // flag, we need to use the runtime function so that the new function 1136 // flag, we need to use the runtime function so that the new function
1137 // we are creating here gets a chance to have its code optimized and 1137 // we are creating here gets a chance to have its code optimized and
1138 // doesn't just get a copy of the existing unoptimized code. 1138 // doesn't just get a copy of the existing unoptimized code.
1139 if (!FLAG_always_opt && !FLAG_prepare_always_opt && !pretenure && 1139 if (!FLAG_always_opt &&
1140 scope()->is_function_scope()) { 1140 !FLAG_prepare_always_opt &&
1141 !pretenure &&
1142 scope()->is_function_scope() &&
1143 info->num_literals() == 0) {
1141 FastNewClosureStub stub(isolate(), info->language_mode(), info->kind()); 1144 FastNewClosureStub stub(isolate(), info->language_mode(), info->kind());
1142 __ mov(ebx, Immediate(info)); 1145 __ mov(ebx, Immediate(info));
1143 __ CallStub(&stub); 1146 __ CallStub(&stub);
1144 } else { 1147 } else {
1145 __ push(Immediate(info)); 1148 __ push(Immediate(info));
1146 __ CallRuntime(pretenure ? Runtime::kNewClosure_Tenured 1149 __ CallRuntime(pretenure ? Runtime::kNewClosure_Tenured
1147 : Runtime::kNewClosure); 1150 : Runtime::kNewClosure);
1148 } 1151 }
1149 context()->Plug(eax); 1152 context()->Plug(eax);
1150 } 1153 }
(...skipping 3551 matching lines...) Expand 10 before | Expand all | Expand 10 after
4702 Assembler::target_address_at(call_target_address, 4705 Assembler::target_address_at(call_target_address,
4703 unoptimized_code)); 4706 unoptimized_code));
4704 return OSR_AFTER_STACK_CHECK; 4707 return OSR_AFTER_STACK_CHECK;
4705 } 4708 }
4706 4709
4707 4710
4708 } // namespace internal 4711 } // namespace internal
4709 } // namespace v8 4712 } // namespace v8
4710 4713
4711 #endif // V8_TARGET_ARCH_X87 4714 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « no previous file | src/x87/builtins-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698