Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1673603002: depot_tools: use package_resource to locate gclient.py (Closed)

Created:
4 years, 10 months ago by Paweł Hajdan Jr.
Modified:
4 years, 10 months ago
Reviewers:
Michael Achenbach
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

depot_tools: use package_resource to locate gclient.py BUG=437264 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298612

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M recipe_modules/gclient/api.py View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/gclient/example.expected/basic.json View 7 chunks +7 lines, -7 lines 0 comments Download
M recipe_modules/gclient/example.expected/revision.json View 7 chunks +7 lines, -7 lines 0 comments Download
M recipe_modules/gclient/example.expected/tryserver.json View 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Paweł Hajdan Jr.
The error it's fixing is from https://chromium-swarm-dev.appspot.com/user/task/2cc72294d3065a10 : @@@STEP_LOG_LINE@exception@Traceback (most recent call last):@@@ @@@STEP_LOG_LINE@exception@ File ...
4 years, 10 months ago (2016-02-05 10:33:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1673603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1673603002/1
4 years, 10 months ago (2016-02-05 10:34:05 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-05 10:35:56 UTC) #6
Michael Achenbach
lgtm
4 years, 10 months ago (2016-02-05 10:52:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1673603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1673603002/1
4 years, 10 months ago (2016-02-05 10:56:56 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 10:59:03 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298612

Powered by Google App Engine
This is Rietveld 408576698