Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 1673583002: [wasm] min/max does not return signaling NaNs anymore. (Closed)

Created:
4 years, 10 months ago by ahaas
Modified:
4 years, 10 months ago
Reviewers:
titzer, binji
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] min/max does not return signaling NaNs anymore. To avoid returning a signaling NaN the result is multiplied by 1.0. R=titzer@chromium.org, binji@chromium.org BUG=4733 LOG=Y Committed: https://crrev.com/563539a3d65763d2608e88479cf5666a8b912234 Cr-Commit-Position: refs/heads/master@{#33783}

Patch Set 1 #

Patch Set 2 : turned off tests on arm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -8 lines) Patch
M src/compiler/wasm-compiler.cc View 4 chunks +24 lines, -8 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ahaas
4 years, 10 months ago (2016-02-05 09:55:32 UTC) #1
ahaas
On 2016/02/05 at 09:55:32, ahaas wrote: > In the current implementation arm always returns a ...
4 years, 10 months ago (2016-02-05 10:54:30 UTC) #2
titzer
lgtm
4 years, 10 months ago (2016-02-05 13:12:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1673583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1673583002/20001
4 years, 10 months ago (2016-02-05 14:35:37 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-05 14:59:44 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 15:00:29 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/563539a3d65763d2608e88479cf5666a8b912234
Cr-Commit-Position: refs/heads/master@{#33783}

Powered by Google App Engine
This is Rietveld 408576698