Moving swap IWYU from <algorithm> to <utility>.

Moving swap IWYU from <algorithm> to <utility>.

In C++11 std::swap was moved from <algorithm> to <utility>. As such,
lint needed to be updated to look for/suggest <utility> when it finds
std::swap. The IWYU logic is a little bit different for <utility>
functions, including swap, because they do not typically include
template parameters, unlike most other std:: functions. Reworked the
existing algorithm pattern to be more generic and support multiple
differet headers. Did not rename/all caps _re_pattern_templates as it
is referenced/modified outside of cpplint.py.

BUG=584689
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298622

[skym, 2016-02-05 16:37:03]

Description was changed from

==========
Moving swap IWYU from <algorithm> to <vector>.

In C++11 std::swap was moved from <algorithm> to <utility>. As such,
lint needed to be updated to look for/suggest <utility> when it finds
std::swap. The IWYU logic is a little bit different for <utility>
functions, including swap, because they do not typically include
template parameters, unlike most other std:: functions. Reworked the
existing algorithm pattern to be more generic and support multiple
differet headers. Did not rename/all caps _re_pattern_templates as it
is referenced/modified outside of cpplint.py.

BUG=584689
==========

to

==========
Moving swap IWYU from <algorithm> to <vector>.

In C++11 std::swap was moved from <algorithm> to <utility>. As such,
lint needed to be updated to look for/suggest <utility> when it finds
std::swap. The IWYU logic is a little bit different for <utility>
functions, including swap, because they do not typically include
template parameters, unlike most other std:: functions. Reworked the
existing algorithm pattern to be more generic and support multiple
differet headers. Did not rename/all caps _re_pattern_templates as it
is referenced/modified outside of cpplint.py.

BUG=584689
==========

[skym, 2016-02-05 16:37:04]

skym@chromium.org changed reviewers:
+ dpranke@chromium.org

[skym, 2016-02-05 16:39:20]

PTAL

[skym, 2016-02-05 16:41:46]

Description was changed from

==========
Moving swap IWYU from <algorithm> to <vector>.

In C++11 std::swap was moved from <algorithm> to <utility>. As such,
lint needed to be updated to look for/suggest <utility> when it finds
std::swap. The IWYU logic is a little bit different for <utility>
functions, including swap, because they do not typically include
template parameters, unlike most other std:: functions. Reworked the
existing algorithm pattern to be more generic and support multiple
differet headers. Did not rename/all caps _re_pattern_templates as it
is referenced/modified outside of cpplint.py.

BUG=584689
==========

to

==========
Moving swap IWYU from <algorithm> to <utility>.

In C++11 std::swap was moved from <algorithm> to <utility>. As such,
lint needed to be updated to look for/suggest <utility> when it finds
std::swap. The IWYU logic is a little bit different for <utility>
functions, including swap, because they do not typically include
template parameters, unlike most other std:: functions. Reworked the
existing algorithm pattern to be more generic and support multiple
differet headers. Did not rename/all caps _re_pattern_templates as it
is referenced/modified outside of cpplint.py.

BUG=584689
==========

[Dirk Pranke, 2016-02-05 20:40:38]

lgtm w/ one nit.

https://codereview.chromium.org/1673543004/diff/2/cpplint.py
File cpplint.py (right):

https://codereview.chromium.org/1673543004/diff/2/cpplint.py#newcode5510
cpplint.py:5510: _RE_PATTERN_HEADERS_MAYBE_TEMPLATES = []
this isn't a constant, so I wouldn't use all-caps for the name.

[skym, 2016-02-05 20:52:58]

https://codereview.chromium.org/1673543004/diff/2/cpplint.py
File cpplint.py (right):

https://codereview.chromium.org/1673543004/diff/2/cpplint.py#newcode5510
cpplint.py:5510: _RE_PATTERN_HEADERS_MAYBE_TEMPLATES = []
On 2016/02/05 20:40:38, Dirk Pranke wrote:
> this isn't a constant, so I wouldn't use all-caps for the name.

Done.

[skym, 2016-02-05 20:53:27]

The CQ bit was checked by skym@chromium.org

[skym, 2016-02-05 20:53:27]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1673543004/#ps30001
(title: "Lower casing name of non-constant.")

[commit-bot: I haz the power, 2016-02-05 20:53:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1673543004/30001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1673543004/30001

[commit-bot: I haz the power, 2016-02-05 20:55:12]

Description was changed from

==========
Moving swap IWYU from <algorithm> to <utility>.

In C++11 std::swap was moved from <algorithm> to <utility>. As such,
lint needed to be updated to look for/suggest <utility> when it finds
std::swap. The IWYU logic is a little bit different for <utility>
functions, including swap, because they do not typically include
template parameters, unlike most other std:: functions. Reworked the
existing algorithm pattern to be more generic and support multiple
differet headers. Did not rename/all caps _re_pattern_templates as it
is referenced/modified outside of cpplint.py.

BUG=584689
==========

to

==========
Moving swap IWYU from <algorithm> to <utility>.

In C++11 std::swap was moved from <algorithm> to <utility>. As such,
lint needed to be updated to look for/suggest <utility> when it finds
std::swap. The IWYU logic is a little bit different for <utility>
functions, including swap, because they do not typically include
template parameters, unlike most other std:: functions. Reworked the
existing algorithm pattern to be more generic and support multiple
differet headers. Did not rename/all caps _re_pattern_templates as it
is referenced/modified outside of cpplint.py.

BUG=584689

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298622
==========

[commit-bot: I haz the power, 2016-02-05 20:55:13]

Committed patchset #3 (id:30001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298622