Split out fallback stack limit determination.

third_party/WebKit/Source/platform/heap/StackFrameDepth.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/heap/StackFrameDepth.h"
 
 #include "public/platform/Platform.h"
 
 #if OS(WIN)
 #include <stddef.h>
@@ skipping 14 matching lines @@
 #endif
 
 // NEVER_INLINE ensures that |dummy| array on configureLimit() is not optimized away,
 // and the stack frame base register is adjusted |kSafeStackFrameSize|.
 NEVER_INLINE static uintptr_t currentStackFrameBaseOnCallee(const char* dummy)
 {
     s_avoidOptimization = dummy;
     return StackFrameDepth::currentStackFrame();
 }
 
+uintptr_t StackFrameDepth::getFallbackStackLimit()
+{
+    // Fallback version.
+    // Allocate a 32KB object on stack and query stack frame base after it.

[haraken, 2016/02/05 09:05:57]

If we take this approach, I think we can increase the threshold. Shall we try
128 KB (for example) and see if we get crash reports?

[sof, 2016/02/05 09:13:01]

On Windows this method will never be executed, so that won't make much of a
difference for the associated bug.

i.e., the compiler will hoist & include _chkstk() calls in prologues if the
method/function makes > 4k of local stack allocations -- the check isn't delayed
until the stack pointer is actually bumped. Which it will never be on Windows
where we can determine stack size reliably.

+    char dummy[kSafeStackFrameSize];
+
+    // Check that the stack frame can be used.
+    dummy[sizeof(dummy) - 1] = 0;
+#if ENABLE(ASSERT)
+    // Use a larger stack limit for what's acceptable if the platform
+    // thread ends up using the fallback size to decide if switching to
+    // lazy marking is in order.
+    s_isUsingFallbackStackSize = true;
+#endif
+    return currentStackFrameBaseOnCallee(dummy);
+}
+
 void StackFrameDepth::enableStackLimit()
 {
 #if ENABLE(ASSERT)
     s_isEnabled = true;
     s_isUsingFallbackStackSize = false;
 #endif
 
-    static const int kStackRoomSize = 1024;
-
     size_t stackSize = getUnderestimatedStackSize();
-    if (stackSize) {
-        Address stackBase = reinterpret_cast<Address>(getStackStart());
-        RELEASE_ASSERT(stackSize > static_cast<const size_t>(kStackRoomSize));
-        size_t stackRoom = stackSize - kStackRoomSize;
-        RELEASE_ASSERT(stackBase > reinterpret_cast<Address>(stackRoom));
-        s_stackFrameLimit = reinterpret_cast<uintptr_t>(stackBase - stackRoom);
+    if (!stackSize) {

[haraken, 2016/02/05 09:19:02]

It would be worth having a comment and mention on what platforms we fall back to
the fallback stack size.

[sof, 2016/02/05 10:09:34]

Yes, added.

Having a non-zero default estimate for pthreads-based platforms, is probably
worth it. But not by this CL.

+        s_stackFrameLimit = getFallbackStackLimit();
         return;
     }
 
-    // Fallback version
-    // Allocate a 32KB object on stack and query stack frame base after it.
-    char dummy[kSafeStackFrameSize];
-    s_stackFrameLimit = currentStackFrameBaseOnCallee(dummy);
+    static const int kStackRoomSize = 1024;
 
-    // Assert that the stack frame can be used.
-    dummy[sizeof(dummy) - 1] = 0;
-#if ENABLE(ASSERT)
-    // Use a larger stack limit for what's acceptable if the platform
-    // thread ends up using the fallback size to decide if switching to
-    // lazy marking is in order.
-    s_isUsingFallbackStackSize = true;
-#endif
+    Address stackBase = reinterpret_cast<Address>(getStackStart());
+    RELEASE_ASSERT(stackSize > static_cast<const size_t>(kStackRoomSize));
+    size_t stackRoom = stackSize - kStackRoomSize;
+    RELEASE_ASSERT(stackBase > reinterpret_cast<Address>(stackRoom));
+    s_stackFrameLimit = reinterpret_cast<uintptr_t>(stackBase - stackRoom);
 }
 
 size_t StackFrameDepth::getUnderestimatedStackSize()
 {
     // FIXME: ASAN bot uses a fake stack as a thread stack frame,
     // and its size is different from the value which APIs tells us.
 #if defined(ADDRESS_SANITIZER)
     return 0;
 #endif
 
@@ skipping 97 matching lines @@
     return reinterpret_cast<void*>(__readgsqword(offsetof(NT_TIB64, StackBase)));
 #else
     return reinterpret_cast<void*>(__readfsdword(offsetof(NT_TIB, StackBase)));
 #endif
 #else
 #error Unsupported getStackStart on this platform.
 #endif
 }
 
 } // namespace blink