Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Issue 1673533002: X87: Write barrier for storing a code entry, and usage in CompileLazy builtin. (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Write barrier for storing a code entry, and usage in CompileLazy builtin. port 477e133698aa2f0a40643f316c31d17347be2de7 (r33718) original commit message: BUG= Committed: https://crrev.com/acab11e0cb719e7ff7dc3f5b73782b332860d338 Cr-Commit-Position: refs/heads/master@{#33758}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -14 lines) Patch
M src/x87/code-stubs-x87.h View 1 chunk +2 lines, -14 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 2 chunks +15 lines, -0 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 2 chunks +112 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-05 06:30:50 UTC) #2
Weiliang
lgtm
4 years, 10 months ago (2016-02-05 06:45:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1673533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1673533002/1
4 years, 10 months ago (2016-02-05 06:47:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-05 07:05:48 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 07:06:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/acab11e0cb719e7ff7dc3f5b73782b332860d338
Cr-Commit-Position: refs/heads/master@{#33758}

Powered by Google App Engine
This is Rietveld 408576698