Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: src/objects.cc

Issue 16735003: Fix re-initialization of existing double field. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-2717.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 4ee7734a2f78c91cfce410268e5954ab35fd614d..fc42fc7ecc43c263aef2dd187b5ef21dae588f73 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -4026,6 +4026,7 @@ MaybeObject* JSObject::SetLocalPropertyIgnoreAttributes(
Representation representation = lookup.representation();
Representation value_representation =
value->OptimalRepresentation(value_type);
+ if (value_representation.IsNone()) break;
if (!value_representation.fits_into(representation)) {
MaybeObject* maybe_failure = self->GeneralizeFieldRepresentation(
lookup.GetDescriptorIndex(), value_representation);
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-2717.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698