Mojo: Fix uses of (MOJO_)MOVE_ONLY_TYPE_FOR_CPP_03().

Mojo: Fix uses of (MOJO_)MOVE_ONLY_TYPE_FOR_CPP_03().

Apparently, it's not supposed to be followed by a semicolon (which is
extraneous). No compiler has ever complained about it; I don't know what
the standard says about extra semicolons in class definitions, but
conceivably a compiler might still warn about it.

R=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252515

[darin (slow to review), 2014-02-21 06:04:51]

LGTM
On Feb 20, 2014 9:51 PM, <viettrungluu@chromium.org> wrote:

> Reviewers: darin,
>
> Description:
> Mojo: Fix uses of (MOJO_)MOVE_ONLY_TYPE_FOR_CPP_03().
>
> Apparently, it's not supposed to be followed by a semicolon (which is
> extraneous). No compiler has ever complained about it; I don't know what
> the standard says about extra semicolons in class definitions, but
> conceivably a compiler might still warn about it.
>
> R=darin@chromium.org
>
> Please review this at https://codereview.chromium.org/167343007/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+3, -3 lines):
>   mojo/public/bindings/remote_ptr.h
>   mojo/public/system/core_cpp.h
>   mojo/system/embedder/scoped_platform_handle.h
>
>
> Index: mojo/public/bindings/remote_ptr.h
> diff --git a/mojo/public/bindings/remote_ptr.h
> b/mojo/public/bindings/remote_ptr.h
> index 10906c304693675747563f51e3ef8faf1a7e95fc..
> cb5c859f75b520634741d4199ab3131a31bc1a9f 100644
> --- a/mojo/public/bindings/remote_ptr.h
> +++ b/mojo/public/bindings/remote_ptr.h
> @@ -71,7 +71,7 @@ namespace mojo {
>  template <typename S>
>  class RemotePtr {
>    struct State;
> -  MOJO_MOVE_ONLY_TYPE_FOR_CPP_03(RemotePtr, RValue);
> +  MOJO_MOVE_ONLY_TYPE_FOR_CPP_03(RemotePtr, RValue)
>
>   public:
>    RemotePtr() : state_(NULL) {}
> Index: mojo/public/system/core_cpp.h
> diff --git a/mojo/public/system/core_cpp.h b/mojo/public/system/core_cpp.h
> index 8c581fbb8c2b4d97f38f0870884763f2d2192bab..
> b276eed0bd1ddb7a10a46476b4a1513747688e7b 100644
> --- a/mojo/public/system/core_cpp.h
> +++ b/mojo/public/system/core_cpp.h
> @@ -28,7 +28,7 @@ inline MojoTimeTicks GetTimeTicksNow() {
>  // like the C++11 |unique_ptr|.
>  template <class HandleType>
>  class ScopedHandleBase {
> -  MOJO_MOVE_ONLY_TYPE_FOR_CPP_03(ScopedHandleBase, RValue);
> +  MOJO_MOVE_ONLY_TYPE_FOR_CPP_03(ScopedHandleBase, RValue)
>
>   public:
>    ScopedHandleBase() {}
> Index: mojo/system/embedder/scoped_platform_handle.h
> diff --git a/mojo/system/embedder/scoped_platform_handle.h
> b/mojo/system/embedder/scoped_platform_handle.h
> index 202871820a49f22f0c99b464ad33215a184c674b..
> 80489c335bf49b9d25c7c088f0eba84d81a9baf4 100644
> --- a/mojo/system/embedder/scoped_platform_handle.h
> +++ b/mojo/system/embedder/scoped_platform_handle.h
> @@ -14,7 +14,7 @@ namespace mojo {
>  namespace embedder {
>
>  class MOJO_SYSTEM_IMPL_EXPORT ScopedPlatformHandle {
> -  MOVE_ONLY_TYPE_FOR_CPP_03(ScopedPlatformHandle, RValue);
> +  MOVE_ONLY_TYPE_FOR_CPP_03(ScopedPlatformHandle, RValue)
>
>   public:
>    ScopedPlatformHandle() {}
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[viettrungluu, 2014-02-21 06:38:08]

Committed patchset #1 manually as r252515 (presubmit successful).