Issue 167343003: Add latency metric mean_js_touch_scroll_latency for JS touch handler driven scroll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 167343003: Add latency metric mean_js_touch_scroll_latency for JS touch handler driven scroll (Closed)

Created:
6 years, 10 months ago by Yufeng Shen (Slow to review)

Modified:
6 years, 10 months ago

Reviewers:
nduca

CC:
chromium-reviews, chrome-speed-team+watch_google.com, jdduke (slow)

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add latency metric mean_js_touch_scroll_latency for JS touch handler driven scroll The performance of GestureScrollUpdate driven scroll and JS touch handler driven scroll can be quite different. So it seems more useful to have a separate metric for each one. BUG=246034 TEST=1. smoothness test on tough_scheduling_cases with page-filter=touch_handler_scrolling shows result of mean_js_touch_scroll_latency. 2. smoothness test on tough_scheduling_cases with page-filter=simpel_text_page shows result of mean_touch_scroll_latency. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251845

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -19 lines)			Patch
M	tools/perf/metrics/rendering_stats.py	View	6 chunks	+22 lines, -15 lines	0 comments	Download
M	tools/perf/metrics/rendering_stats_unittest.py	View	8 chunks	+28 lines, -4 lines	0 comments	Download
M	tools/perf/metrics/smoothness.py	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

nduca

lgtm should we tell qyearsley to fix the dashbaord once this lands?

6 years, 10 months ago (2014-02-18 18:51:45 UTC) #2

Yufeng Shen (Slow to review)

The CQ bit was checked by miletus@chromium.org

6 years, 10 months ago (2014-02-18 19:33:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/167343003/1

6 years, 10 months ago (2014-02-18 19:33:07 UTC) #4

Message was sent while issue was closed.

Change committed as 251845

Expand Messages | Collapse Messages