Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2861)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/metrics/histogram.h

Issue 167343002: Make code generated for histogram macros more compact. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/metrics/histogram_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/histogram.h
===================================================================
--- base/metrics/histogram.h (revision 251312)
+++ base/metrics/histogram.h (working copy)
@@ -155,8 +155,8 @@
base::subtle::Release_Store(&atomic_histogram_pointer, \
reinterpret_cast<base::subtle::AtomicWord>(histogram_pointer)); \
} \
- DCHECK_EQ(histogram_pointer->histogram_name(), \
- std::string(constant_histogram_name)); \
+ if (DCHECK_IS_ON()) \
jar (doing other things) 2014/02/15 00:50:42 Am I correct, that this is an effort to reduce the
+ histogram_pointer->CheckName(constant_histogram_name); \
histogram_pointer->histogram_add_method_invocation; \
} while (0)
« no previous file with comments | « no previous file | base/metrics/histogram_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698