Views - fix up layout of a couple dialogs

chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

Index: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
diff --git a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
index 451cda3d930734d2fd05c69c4991e11329a464c0..a1ae82edf96dec2f8881c502dcb8f4cc6282a117 100644
--- a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
+++ b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
@@ -44,6 +44,7 @@
 #include "ui/views/controls/menu/menu_runner.h"
 #include "ui/views/layout/box_layout.h"
 #include "ui/views/layout/grid_layout.h"
+#include "ui/views/layout/layout_constants.h"
 
 namespace {
 
@@ -56,9 +57,6 @@ const int kButtonBorderSize = 2;
 // (Square) pixel size of icon.
 const int kIconSize = 18;
 
-// Number of pixels to indent the permission request labels.
-const int kPermissionIndentSpacing = 12;
-
 }  // namespace
 
 // This class is a MenuButton which is given a PermissionMenuModel. It
@@ -235,7 +233,8 @@ PermissionsBubbleDelegateView::PermissionsBubbleDelegateView(
 
     views::View* label_container = new views::View();
     label_container->SetLayoutManager(new views::BoxLayout(
-        views::BoxLayout::kHorizontal, kPermissionIndentSpacing, 0, 0));

[Evan Stade, 2016/02/08 23:00:49]

this 0 used to be kBubbleOuterMargin (5) but I deleted it because I was getting
rid of custom margins. Turns out that was over-zealous because we do need some
value here, so I changed to kItemLabelSpacing.

[msw, 2016/02/09 00:04:36]

Is this for 585076? It doesn't seem like a 0 here would have caused too much
padding there, nor do I see where this CL attempts to fix that defect.

[Evan Stade, 2016/02/09 23:47:58]

sorry, wrong bug, should have been crbug.com/585014

crbug.com/585076 is not related to my recent bubble work (as you can see the
bisect predates the bubble changes)

+        views::BoxLayout::kHorizontal, views::kCheckboxIndent, 0,
+        views::kItemLabelSpacing));
     views::ImageView* icon = new views::ImageView();
     gfx::VectorIconId vector_id = requests[index]->GetVectorIconId();
     if (vector_id != gfx::VectorIconId::VECTOR_ICON_NONE) {