Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1673393002: Return early from VisualViewport::initializeScrollbars if not attached yet. (Closed)

Created:
4 years, 10 months ago by dgozman
Modified:
4 years, 10 months ago
Reviewers:
bokan, pfeldman
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Return early from VisualViewport::initializeScrollbars if not attached yet. During navigation with DevTools emulation enabled, we end up calling initializeScrollbars too early. Just ignore it. BUG=584614 Committed: https://crrev.com/73b58476391aec96038fc6716c5cd06280ea409c Cr-Commit-Position: refs/heads/master@{#374299}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dgozman
David, could you please take a look? +Pavel for owners.
4 years, 10 months ago (2016-02-08 22:19:52 UTC) #2
bokan
lgtm
4 years, 10 months ago (2016-02-08 22:36:17 UTC) #3
pfeldman
lgtm
4 years, 10 months ago (2016-02-09 00:50:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1673393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1673393002/1
4 years, 10 months ago (2016-02-09 01:16:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 04:27:33 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 04:29:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73b58476391aec96038fc6716c5cd06280ea409c
Cr-Commit-Position: refs/heads/master@{#374299}

Powered by Google App Engine
This is Rietveld 408576698