Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1673373002: Test some corner cases of shadowing between scopes when summarizing constants. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Test some corner cases of shadowing between scopes when summarizing constants. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/6841968ea6990aa094458d2ccb34d5d9ae63972e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M pkg/analyzer/test/src/summary/summary_common.dart View 2 chunks +52 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-08 20:32:23 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-08 20:34:49 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-08 20:52:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6841968ea6990aa094458d2ccb34d5d9ae63972e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698