Issue 167333003: Make CollectionIndexCache::setCachedNode() private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 167333003: Make CollectionIndexCache::setCachedNode() private (Closed)

Created:
6 years, 10 months ago by Inactive

Modified:
6 years, 10 months ago

Reviewers:
rwlbuis

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Make CollectionIndexCache::setCachedNode() private Make CollectionIndexCache::setCachedNode() private. We no longer need it to be public as it is never called from the outside. It is better for the class to handle its own cache. R=rob.buis@samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167222

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
	M	Source/core/html/CollectionIndexCache.h	View		2 chunks	+6 lines, -7 lines	0 comments	Download

Total messages: 5 (0 generated)

rwlbuis

On 2014/02/14 20:22:27, Chris Dumez wrote: lgtm. Nit, in the ChangeLog I think you want ...

6 years, 10 months ago (2014-02-14 20:23:58 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/167333003/1

6 years, 10 months ago (2014-02-14 20:26:16 UTC) #4

Inactive

6 years, 10 months ago (2014-02-14 20:35:21 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r167222 (presubmit successful).