Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: trunk/src/content/renderer/v8_value_converter_impl.h

Issue 16733002: Revert 204057 "Recurse to a maximum depth of 10 in v8_value_conv..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_V8_VALUE_CONVERTER_IMPL_H_ 5 #ifndef CONTENT_RENDERER_V8_VALUE_CONVERTER_IMPL_H_
6 #define CONTENT_RENDERER_V8_VALUE_CONVERTER_IMPL_H_ 6 #define CONTENT_RENDERER_V8_VALUE_CONVERTER_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 21 matching lines...) Expand all
32 virtual void SetStripNullFromObjects(bool val) OVERRIDE; 32 virtual void SetStripNullFromObjects(bool val) OVERRIDE;
33 virtual v8::Handle<v8::Value> ToV8Value( 33 virtual v8::Handle<v8::Value> ToV8Value(
34 const base::Value* value, 34 const base::Value* value,
35 v8::Handle<v8::Context> context) const OVERRIDE; 35 v8::Handle<v8::Context> context) const OVERRIDE;
36 virtual base::Value* FromV8Value( 36 virtual base::Value* FromV8Value(
37 v8::Handle<v8::Value> value, 37 v8::Handle<v8::Value> value,
38 v8::Handle<v8::Context> context) const OVERRIDE; 38 v8::Handle<v8::Context> context) const OVERRIDE;
39 39
40 private: 40 private:
41 friend class ScopedAvoidIdentityHashForTesting; 41 friend class ScopedAvoidIdentityHashForTesting;
42 42 typedef std::multimap<int, v8::Handle<v8::Object> > HashToHandleMap;
43 class FromV8ValueState;
44 43
45 v8::Handle<v8::Value> ToV8ValueImpl(const base::Value* value) const; 44 v8::Handle<v8::Value> ToV8ValueImpl(const base::Value* value) const;
46 v8::Handle<v8::Value> ToV8Array(const base::ListValue* list) const; 45 v8::Handle<v8::Value> ToV8Array(const base::ListValue* list) const;
47 v8::Handle<v8::Value> ToV8Object( 46 v8::Handle<v8::Value> ToV8Object(
48 const base::DictionaryValue* dictionary) const; 47 const base::DictionaryValue* dictionary) const;
49 v8::Handle<v8::Value> ToArrayBuffer(const base::BinaryValue* value) const; 48 v8::Handle<v8::Value> ToArrayBuffer(const base::BinaryValue* value) const;
50 49
51 base::Value* FromV8ValueImpl(v8::Handle<v8::Value> value, 50 base::Value* FromV8ValueImpl(v8::Handle<v8::Value> value,
52 FromV8ValueState* state) const; 51 HashToHandleMap* unique_map) const;
53 base::Value* FromV8Array(v8::Handle<v8::Array> array, 52 base::Value* FromV8Array(v8::Handle<v8::Array> array,
54 FromV8ValueState* state) const; 53 HashToHandleMap* unique_map) const;
55 54
56 // This will convert objects of type ArrayBuffer or any of the 55 // This will convert objects of type ArrayBuffer or any of the
57 // ArrayBufferView subclasses. The return value will be NULL if |value| is 56 // ArrayBufferView subclasses. The return value will be NULL if |value| is
58 // not one of these types. 57 // not one of these types.
59 base::BinaryValue* FromV8Buffer(v8::Handle<v8::Value> value) const; 58 base::BinaryValue* FromV8Buffer(v8::Handle<v8::Value> value) const;
60 59
61 base::Value* FromV8Object(v8::Handle<v8::Object> object, 60 base::Value* FromV8Object(v8::Handle<v8::Object> object,
62 FromV8ValueState* state) const; 61 HashToHandleMap* unique_map) const;
62
63 // If |handle| is not in |map|, then add it to |map| and return true.
64 // Otherwise do nothing and return false. Here "A is unique" means that no
65 // other handle B in the map points to the same object as A. Note that A can
66 // be unique even if there already is another handle with the same identity
67 // hash (key) in the map, because two objects can have the same hash.
68 bool UpdateAndCheckUniqueness(HashToHandleMap* map,
69 v8::Handle<v8::Object> handle) const;
63 70
64 // If true, we will convert Date JavaScript objects to doubles. 71 // If true, we will convert Date JavaScript objects to doubles.
65 bool date_allowed_; 72 bool date_allowed_;
66 73
67 // If true, we will convert RegExp JavaScript objects to string. 74 // If true, we will convert RegExp JavaScript objects to string.
68 bool reg_exp_allowed_; 75 bool reg_exp_allowed_;
69 76
70 // If true, we will convert Function JavaScript objects to dictionaries. 77 // If true, we will convert Function JavaScript objects to dictionaries.
71 bool function_allowed_; 78 bool function_allowed_;
72 79
73 // If true, undefined and null values are ignored when converting v8 objects 80 // If true, undefined and null values are ignored when converting v8 objects
74 // into Values. 81 // into Values.
75 bool strip_null_from_objects_; 82 bool strip_null_from_objects_;
76 83
77 bool avoid_identity_hash_for_testing_; 84 bool avoid_identity_hash_for_testing_;
78 85
79 DISALLOW_COPY_AND_ASSIGN(V8ValueConverterImpl); 86 DISALLOW_COPY_AND_ASSIGN(V8ValueConverterImpl);
80 }; 87 };
81 88
82 } // namespace content 89 } // namespace content
83 90
84 #endif // CONTENT_RENDERER_V8_VALUE_CONVERTER_IMPL_H_ 91 #endif // CONTENT_RENDERER_V8_VALUE_CONVERTER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698