MSE: Use CHECKs to obtain more detail on hard-to-repro crashes

MSE: Use CHECKs to obtain more detail on hard-to-repro crashes

Changes some existing DCHECKs to CHECKs, adds a further CHECK, and
includes some detail in the CHECK message to test hypotheses around
potential causes of crashes tracked in the linked bugs (and b/26908337).

BUG=569755, 584422
R=chcunningham@chromium.org

Committed: https://crrev.com/0793620595543608f390a3993234fb344fc8f1a2
Cr-Commit-Position: refs/heads/master@{#374231}

[wolenetz, 2016-02-08 22:32:00]

The CQ bit was checked by wolenetz@chromium.org to run a CQ dry run

[wolenetz, 2016-02-08 22:32:46]

Please take a look. I'd like to see if Canary or Dev branch repro can help find
the root-cause of the linked bugs using this CL.

[commit-bot: I haz the power, 2016-02-08 22:35:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1673293003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1673293003/20001

[chcunningham, 2016-02-08 23:35:38]

I'm curious what the dumps showed. Value of index in the dump should be strong
hint.

LGTM

[chcunningham, 2016-02-08 23:38:11]

The CQ bit was unchecked by chcunningham@chromium.org

[chcunningham, 2016-02-08 23:38:11]

The CQ bit was checked by chcunningham@chromium.org

[commit-bot: I haz the power, 2016-02-08 23:38:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1673293003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1673293003/20001

[wolenetz, 2016-02-08 23:42:58]

On 2016/02/08 23:35:38, chcunningham wrote:
> I'm curious what the dumps showed. Value of index in the dump should be strong
> hint.
> 
> LGTM

Agreed. I wanted to get the Canary CHECK build going just in case dump
investigation was inconclusive. THanks for review.

[commit-bot: I haz the power, 2016-02-09 00:18:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 00:18:40]

Failed to request the patch to try. Please note that binary files are still
unsupported at the moment, this is being worked on.

Thanks for your patience.

Transient error: No JSON object could be decoded

[wolenetz, 2016-02-09 00:22:25]

The CQ bit was checked by wolenetz@chromium.org

[commit-bot: I haz the power, 2016-02-09 00:23:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-09 00:24:58]

Description was changed from

==========
MSE: Use CHECKs to obtain more detail on hard-to-repro crashes

Changes some existing DCHECKs to CHECKs, adds a further CHECK, and
includes some detail in the CHECK message to test hypotheses around
potential causes of crashes tracked in the linked bugs (and b/26908337).

BUG=569755,584422
R=chcunningham@chromium.org
==========

to

==========
MSE: Use CHECKs to obtain more detail on hard-to-repro crashes

Changes some existing DCHECKs to CHECKs, adds a further CHECK, and
includes some detail in the CHECK message to test hypotheses around
potential causes of crashes tracked in the linked bugs (and b/26908337).

BUG=569755,584422
R=chcunningham@chromium.org

Committed: https://crrev.com/0793620595543608f390a3993234fb344fc8f1a2
Cr-Commit-Position: refs/heads/master@{#374231}
==========

[commit-bot: I haz the power, 2016-02-09 00:24:59]

Patchset 2 (id:??) landed as
https://crrev.com/0793620595543608f390a3993234fb344fc8f1a2
Cr-Commit-Position: refs/heads/master@{#374231}