Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 16732002: remove equality kind from compare nil ic (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/code-stubs.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4747 matching lines...) Expand 10 before | Expand all | Expand 10 after
4758 NilValue nil) { 4758 NilValue nil) {
4759 Label materialize_true, materialize_false; 4759 Label materialize_true, materialize_false;
4760 Label* if_true = NULL; 4760 Label* if_true = NULL;
4761 Label* if_false = NULL; 4761 Label* if_false = NULL;
4762 Label* fall_through = NULL; 4762 Label* fall_through = NULL;
4763 context()->PrepareTest(&materialize_true, &materialize_false, 4763 context()->PrepareTest(&materialize_true, &materialize_false,
4764 &if_true, &if_false, &fall_through); 4764 &if_true, &if_false, &fall_through);
4765 4765
4766 VisitForAccumulatorValue(sub_expr); 4766 VisitForAccumulatorValue(sub_expr);
4767 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false); 4767 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false);
4768 EqualityKind kind = expr->op() == Token::EQ_STRICT 4768 if (expr->op() == Token::EQ_STRICT) {
4769 ? kStrictEquality : kNonStrictEquality;
4770 if (kind == kStrictEquality) {
4771 Heap::RootListIndex nil_value = nil == kNullValue ? 4769 Heap::RootListIndex nil_value = nil == kNullValue ?
4772 Heap::kNullValueRootIndex : 4770 Heap::kNullValueRootIndex :
4773 Heap::kUndefinedValueRootIndex; 4771 Heap::kUndefinedValueRootIndex;
4774 __ LoadRoot(r1, nil_value); 4772 __ LoadRoot(r1, nil_value);
4775 __ cmp(r0, r1); 4773 __ cmp(r0, r1);
4776 Split(eq, if_true, if_false, fall_through); 4774 Split(eq, if_true, if_false, fall_through);
4777 } else { 4775 } else {
4778 Handle<Code> ic = CompareNilICStub::GetUninitialized(isolate(), 4776 Handle<Code> ic = CompareNilICStub::GetUninitialized(isolate(), nil);
4779 kNonStrictEquality,
4780 nil);
4781 CallIC(ic, RelocInfo::CODE_TARGET, expr->CompareOperationFeedbackId()); 4777 CallIC(ic, RelocInfo::CODE_TARGET, expr->CompareOperationFeedbackId());
4782 __ cmp(r0, Operand(0)); 4778 __ cmp(r0, Operand(0));
4783 Split(ne, if_true, if_false, fall_through); 4779 Split(ne, if_true, if_false, fall_through);
4784 } 4780 }
4785 context()->Plug(if_true, if_false); 4781 context()->Plug(if_true, if_false);
4786 } 4782 }
4787 4783
4788 4784
4789 void FullCodeGenerator::VisitThisFunction(ThisFunction* expr) { 4785 void FullCodeGenerator::VisitThisFunction(ThisFunction* expr) {
4790 __ ldr(r0, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset)); 4786 __ ldr(r0, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
4929 *context_length = 0; 4925 *context_length = 0;
4930 return previous_; 4926 return previous_;
4931 } 4927 }
4932 4928
4933 4929
4934 #undef __ 4930 #undef __
4935 4931
4936 } } // namespace v8::internal 4932 } } // namespace v8::internal
4937 4933
4938 #endif // V8_TARGET_ARCH_ARM 4934 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/code-stubs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698