chrome/browser/media/DEPS - Issue 1673183002: Enable H.264 video WebRTC behind run-time flag and add WebRtcBrowserTest for H.264

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/media/DEPS

Issue 1673183002: Enable H.264 video WebRTC behind run-time flag and add WebRtcBrowserTest for H.264 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed gyp/gn deps Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 "+content/public/renderer/renderer_features.h", # For BUILDFLAG(RTC_USE_H264)
	jochen (gone - plz use gerrit) 2016/02/17 10:55:40 browser can't depend on renderer. browser can't depend on renderer. hbos_chromium 2016/02/17 12:27:42 It's only depending on the RTC_USE_H264 buildflag Show quoted text On 2016/02/17 10:55:40, jochen (OOO) wrote: > browser can't depend on renderer. It's only depending on the RTC_USE_H264 buildflag and finch flag (nothing that is otherwise "renderer"). - Do you suggest moving these? To where? Can I place it in content/public/? (I defined the flags to be close to peer_connection_dependency_factory.cc which uses them and initializes webrtc stuff, so it made sense to put the flags for if they should be enabled there. They're not placed in the webrtc repo because that repo does not have access to the deps the flag needs. See previous discussion about the buildflag. Finch flag has not been discussed previously but I placed it where I did for the same reasons.)
	3 "+content/public/renderer/media/webrtc/finch_h264_with_openh264_ffmpeg.h",

2 "+media/audio",	4 "+media/audio",

3 "+media/base",	5 "+media/base",

4 "+media/cast",	6 "+media/cast",

5 "+third_party/libyuv",	7 "+third_party/libyuv",

6 "+third_party/webrtc",	8 "+third_party/webrtc",

7 ]	9 ]

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/media/chrome_webrtc_browsertest.cc » ('j') | chrome/browser/media/chrome_webrtc_browsertest.cc » ('J')