chrome/browser/media/DEPS - Issue 1673183002: Enable H.264 video WebRTC behind run-time flag and add WebRtcBrowserTest for H.264

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/media/DEPS

Issue 1673183002: Enable H.264 video WebRTC behind run-time flag and add WebRtcBrowserTest for H.264 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 "+content/renderer/renderer_features.h", # For BUILDFLAG(RTC_USE_H264).
	hbos_chromium 2016/02/08 15:22:53 \|rtc_use_h264\| is a build flag from the webrtc rep \|rtc_use_h264\| is a build flag from the webrtc repo. BUILDFLAG(RTC_USE_H264) checks if the flag is set or not (renderer_features.h is auto-generated and defines it). This would probably typically be placed where the flag is defined, but because this does not exist in the webrtc repo I defined it closest to where BUILDFLAG(RTC_USE_H264) is used, which was peer_connection_dependency_factory.cc in content/renderer/... Now that we also use it in unittests, DEPS needed to be updated. This is not to say that chrome/browser/media now depends on other content/renderer stuff. Avi (use Gerrit) 2016/02/09 16:45:03 No. content/public is the public API for content. No. content/public is the public API for content. You may not include any file outside of it. hbos_chromium 2016/02/10 09:48:08 OK. I made renderer_features.h content/public/ ins Show quoted text On 2016/02/09 16:45:03, Avi wrote: > No. > > content/public is the public API for content. You may not include any file > outside of it. OK. I made renderer_features.h content/public/ instead. The only "feature" it defines is the RTC_USE_H264 buildflag, no need for that not to be public.
2 "+media/audio",	3 "+media/audio",

3 "+media/base",	4 "+media/base",

4 "+media/cast",	5 "+media/cast",

5 "+third_party/libyuv",	6 "+third_party/libyuv",

6 "+third_party/webrtc",	7 "+third_party/webrtc",

7 ]	8 ]

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/media/chrome_webrtc_browsertest.cc » ('j') | no next file with comments »