Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1673163002: [crankshaft] Allow inlining of base constructors (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Allow inlining of base constructors This speeds up base constructor instantiation by ~3x. BUG= Committed: https://crrev.com/df711833803f51348396109a22bd457d51a22672 Cr-Commit-Position: refs/heads/master@{#33805}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/crankshaft/hydrogen.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 10 months ago (2016-02-08 07:55:06 UTC) #2
Benedikt Meurer
LGTM.
4 years, 10 months ago (2016-02-08 07:55:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1673163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1673163002/1
4 years, 10 months ago (2016-02-08 07:56:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-08 08:42:09 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 08:42:29 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/df711833803f51348396109a22bd457d51a22672
Cr-Commit-Position: refs/heads/master@{#33805}

Powered by Google App Engine
This is Rietveld 408576698