third_party/WebKit/Source/modules/webgl/WebGLRenderbuffer.cpp - Issue 1673113002: Move WebGL1 attachment image type / attachment point matching check to command buffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderbuffer.cpp

Issue 1673113002: Move WebGL1 attachment image type / attachment point matching check to command buffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLRenderbuffer.h ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderbuffer.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderbuffer.cpp b/third_party/WebKit/Source/modules/webgl/WebGLRenderbuffer.cpp

index 8b8b4502682d856f6f899c577c51a34f4e94153c..5c862adaf02071084c2ecccac70cc8d259022d1b 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderbuffer.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderbuffer.cpp

@@ -36,9 +36,6 @@ WebGLRenderbuffer* WebGLRenderbuffer::create(WebGLRenderingContextBase* ctx)

WebGLRenderbuffer::~WebGLRenderbuffer()

{

- // This render buffer (heap) object must finalize itself.

- m_emulatedStencilBuffer.clear();

// See the comment in WebGLObject::detachAndDeleteObject().

detachAndDeleteObject();

}

@@ -57,20 +54,10 @@ void WebGLRenderbuffer::deleteObjectImpl(WebGraphicsContext3D* context3d)

{

context3d->deleteRenderbuffer(m_object);

m_object = 0;

- deleteEmulatedStencilBuffer(context3d);

-void WebGLRenderbuffer::deleteEmulatedStencilBuffer(WebGraphicsContext3D* context3d)

- if (!m_emulatedStencilBuffer)

- return;

- m_emulatedStencilBuffer->deleteObject(context3d);

- m_emulatedStencilBuffer.clear();

}

DEFINE_TRACE(WebGLRenderbuffer)

{

- visitor->trace(m_emulatedStencilBuffer);

WebGLSharedPlatform3DObject::trace(visitor);

}