Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: gpu/command_buffer/service/framebuffer_manager.h

Issue 1673113002: Move WebGL1 attachment image type / attachment point matching check to command buffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GPU_COMMAND_BUFFER_SERVICE_FRAMEBUFFER_MANAGER_H_ 5 #ifndef GPU_COMMAND_BUFFER_SERVICE_FRAMEBUFFER_MANAGER_H_
6 #define GPU_COMMAND_BUFFER_SERVICE_FRAMEBUFFER_MANAGER_H_ 6 #define GPU_COMMAND_BUFFER_SERVICE_FRAMEBUFFER_MANAGER_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 virtual void SetCleared( 45 virtual void SetCleared(
46 RenderbufferManager* renderbuffer_manager, 46 RenderbufferManager* renderbuffer_manager,
47 TextureManager* texture_manager, 47 TextureManager* texture_manager,
48 bool cleared) = 0; 48 bool cleared) = 0;
49 virtual bool IsTexture(TextureRef* texture) const = 0; 49 virtual bool IsTexture(TextureRef* texture) const = 0;
50 virtual bool IsRenderbuffer( 50 virtual bool IsRenderbuffer(
51 Renderbuffer* renderbuffer) const = 0; 51 Renderbuffer* renderbuffer) const = 0;
52 virtual bool CanRenderTo(const FeatureInfo* feature_info) const = 0; 52 virtual bool CanRenderTo(const FeatureInfo* feature_info) const = 0;
53 virtual void DetachFromFramebuffer(Framebuffer* framebuffer) const = 0; 53 virtual void DetachFromFramebuffer(Framebuffer* framebuffer) const = 0;
54 virtual bool ValidForAttachmentType(GLenum attachment_type, 54 virtual bool ValidForAttachmentType(GLenum attachment_type,
55 ContextType context_type,
55 uint32_t max_color_attachments) = 0; 56 uint32_t max_color_attachments) = 0;
56 virtual size_t GetSignatureSize(TextureManager* texture_manager) const = 0; 57 virtual size_t GetSignatureSize(TextureManager* texture_manager) const = 0;
57 virtual void AddToSignature( 58 virtual void AddToSignature(
58 TextureManager* texture_manager, std::string* signature) const = 0; 59 TextureManager* texture_manager, std::string* signature) const = 0;
59 virtual bool FormsFeedbackLoop(TextureRef* texture, GLint level) const = 0; 60 virtual bool FormsFeedbackLoop(TextureRef* texture, GLint level) const = 0;
60 61
61 protected: 62 protected:
62 friend class base::RefCounted<Attachment>; 63 friend class base::RefCounted<Attachment>;
63 virtual ~Attachment() {} 64 virtual ~Attachment() {}
64 }; 65 };
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
311 312
312 scoped_refptr<FramebufferCompletenessCache> framebuffer_combo_complete_cache_; 313 scoped_refptr<FramebufferCompletenessCache> framebuffer_combo_complete_cache_;
313 314
314 DISALLOW_COPY_AND_ASSIGN(FramebufferManager); 315 DISALLOW_COPY_AND_ASSIGN(FramebufferManager);
315 }; 316 };
316 317
317 } // namespace gles2 318 } // namespace gles2
318 } // namespace gpu 319 } // namespace gpu
319 320
320 #endif // GPU_COMMAND_BUFFER_SERVICE_FRAMEBUFFER_MANAGER_H_ 321 #endif // GPU_COMMAND_BUFFER_SERVICE_FRAMEBUFFER_MANAGER_H_
OLDNEW
« no previous file with comments | « gpu/command_buffer/service/feature_info.cc ('k') | gpu/command_buffer/service/framebuffer_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698