Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 167303005: Track field types. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/property.cc ('k') | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4019 matching lines...) Expand 10 before | Expand all | Expand 10 after
4030 LConstantOperand* operand_value = LConstantOperand::cast(instr->value()); 4030 LConstantOperand* operand_value = LConstantOperand::cast(instr->value());
4031 if (chunk_->LookupConstant(operand_value)->HasSmiValue()) { 4031 if (chunk_->LookupConstant(operand_value)->HasSmiValue()) {
4032 DeoptimizeIf(no_condition, instr->environment()); 4032 DeoptimizeIf(no_condition, instr->environment());
4033 } 4033 }
4034 } else { 4034 } else {
4035 if (!hinstr->value()->type().IsHeapObject()) { 4035 if (!hinstr->value()->type().IsHeapObject()) {
4036 Register value = ToRegister(instr->value()); 4036 Register value = ToRegister(instr->value());
4037 Condition cc = masm()->CheckSmi(value); 4037 Condition cc = masm()->CheckSmi(value);
4038 DeoptimizeIf(cc, instr->environment()); 4038 DeoptimizeIf(cc, instr->environment());
4039 4039
4040 // We know that value is a smi now, so we can omit the check below. 4040 // We know now that value is not a smi, so we can omit the check below.
4041 check_needed = OMIT_SMI_CHECK; 4041 check_needed = OMIT_SMI_CHECK;
4042 } 4042 }
4043 } 4043 }
4044 } else if (representation.IsDouble()) { 4044 } else if (representation.IsDouble()) {
4045 ASSERT(transition.is_null()); 4045 ASSERT(transition.is_null());
4046 ASSERT(access.IsInobject()); 4046 ASSERT(access.IsInobject());
4047 ASSERT(!hinstr->NeedsWriteBarrier()); 4047 ASSERT(!hinstr->NeedsWriteBarrier());
4048 XMMRegister value = ToDoubleRegister(instr->value()); 4048 XMMRegister value = ToDoubleRegister(instr->value());
4049 __ movsd(FieldOperand(object, offset), value); 4049 __ movsd(FieldOperand(object, offset), value);
4050 return; 4050 return;
(...skipping 1673 matching lines...) Expand 10 before | Expand all | Expand 10 after
5724 __ bind(deferred->exit()); 5724 __ bind(deferred->exit());
5725 __ bind(&done); 5725 __ bind(&done);
5726 } 5726 }
5727 5727
5728 5728
5729 #undef __ 5729 #undef __
5730 5730
5731 } } // namespace v8::internal 5731 } } // namespace v8::internal
5732 5732
5733 #endif // V8_TARGET_ARCH_X64 5733 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/property.cc ('k') | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698