Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: src/objects-debug.cc

Issue 167303005: Track field types. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
292 DescriptorArray* descriptors = map()->instance_descriptors(); 292 DescriptorArray* descriptors = map()->instance_descriptors();
293 for (int i = 0; i < map()->NumberOfOwnDescriptors(); i++) { 293 for (int i = 0; i < map()->NumberOfOwnDescriptors(); i++) {
294 if (descriptors->GetDetails(i).type() == FIELD) { 294 if (descriptors->GetDetails(i).type() == FIELD) {
295 Representation r = descriptors->GetDetails(i).representation(); 295 Representation r = descriptors->GetDetails(i).representation();
296 int field = descriptors->GetFieldIndex(i); 296 int field = descriptors->GetFieldIndex(i);
297 Object* value = RawFastPropertyAt(field); 297 Object* value = RawFastPropertyAt(field);
298 if (r.IsDouble()) ASSERT(value->IsHeapNumber()); 298 if (r.IsDouble()) ASSERT(value->IsHeapNumber());
299 if (value->IsUninitialized()) continue; 299 if (value->IsUninitialized()) continue;
300 if (r.IsSmi()) ASSERT(value->IsSmi()); 300 if (r.IsSmi()) ASSERT(value->IsSmi());
301 if (r.IsHeapObject()) ASSERT(value->IsHeapObject()); 301 if (r.IsHeapObject()) ASSERT(value->IsHeapObject());
302 HeapType* field_type = descriptors->GetFieldType(i);
303 if (field_type->IsClass()) {
304 Map* map = *field_type->AsClass();
305 CHECK(!map->is_stable() || HeapObject::cast(value)->map() == map);
306 } else if (r.IsNone()) {
307 CHECK(field_type->Is(HeapType::None()));
308 } else {
309 CHECK(HeapType::Any()->Is(field_type));
310 }
302 } 311 }
303 } 312 }
304 } 313 }
305 314
306 // If a GC was caused while constructing this object, the elements 315 // If a GC was caused while constructing this object, the elements
307 // pointer may point to a one pointer filler map. 316 // pointer may point to a one pointer filler map.
308 if (ElementsAreSafeToExamine()) { 317 if (ElementsAreSafeToExamine()) {
309 CHECK_EQ((map()->has_fast_smi_or_object_elements() || 318 CHECK_EQ((map()->has_fast_smi_or_object_elements() ||
310 (elements() == GetHeap()->empty_fixed_array())), 319 (elements() == GetHeap()->empty_fixed_array())),
311 (elements()->map() == GetHeap()->fixed_array_map() || 320 (elements()->map() == GetHeap()->fixed_array_map() ||
(...skipping 871 matching lines...) Expand 10 before | Expand all | Expand 10 after
1183 for (int i = 0; i < number_of_transitions(); ++i) { 1192 for (int i = 0; i < number_of_transitions(); ++i) {
1184 if (!CheckOneBackPointer(current_map, GetTarget(i))) return false; 1193 if (!CheckOneBackPointer(current_map, GetTarget(i))) return false;
1185 } 1194 }
1186 return true; 1195 return true;
1187 } 1196 }
1188 1197
1189 1198
1190 #endif // DEBUG 1199 #endif // DEBUG
1191 1200
1192 } } // namespace v8::internal 1201 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698