Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 167303005: Track field types. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.cc ('k') | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4388 matching lines...) Expand 10 before | Expand all | Expand 10 after
4399 LConstantOperand* operand_value = LConstantOperand::cast(instr->value()); 4399 LConstantOperand* operand_value = LConstantOperand::cast(instr->value());
4400 if (chunk_->LookupConstant(operand_value)->HasSmiValue()) { 4400 if (chunk_->LookupConstant(operand_value)->HasSmiValue()) {
4401 DeoptimizeIf(no_condition, instr->environment()); 4401 DeoptimizeIf(no_condition, instr->environment());
4402 } 4402 }
4403 } else { 4403 } else {
4404 if (!instr->hydrogen()->value()->type().IsHeapObject()) { 4404 if (!instr->hydrogen()->value()->type().IsHeapObject()) {
4405 Register value = ToRegister(instr->value()); 4405 Register value = ToRegister(instr->value());
4406 __ test(value, Immediate(kSmiTagMask)); 4406 __ test(value, Immediate(kSmiTagMask));
4407 DeoptimizeIf(zero, instr->environment()); 4407 DeoptimizeIf(zero, instr->environment());
4408 4408
4409 // We know that value is a smi now, so we can omit the check below. 4409 // We know now that value is not a smi, so we can omit the check below.
4410 check_needed = OMIT_SMI_CHECK; 4410 check_needed = OMIT_SMI_CHECK;
4411 } 4411 }
4412 } 4412 }
4413 } else if (representation.IsDouble()) { 4413 } else if (representation.IsDouble()) {
4414 ASSERT(transition.is_null()); 4414 ASSERT(transition.is_null());
4415 ASSERT(access.IsInobject()); 4415 ASSERT(access.IsInobject());
4416 ASSERT(!instr->hydrogen()->NeedsWriteBarrier()); 4416 ASSERT(!instr->hydrogen()->NeedsWriteBarrier());
4417 if (CpuFeatures::IsSupported(SSE2)) { 4417 if (CpuFeatures::IsSupported(SSE2)) {
4418 CpuFeatureScope scope(masm(), SSE2); 4418 CpuFeatureScope scope(masm(), SSE2);
4419 XMMRegister value = ToDoubleRegister(instr->value()); 4419 XMMRegister value = ToDoubleRegister(instr->value());
(...skipping 2029 matching lines...) Expand 10 before | Expand all | Expand 10 after
6449 __ bind(deferred->exit()); 6449 __ bind(deferred->exit());
6450 __ bind(&done); 6450 __ bind(&done);
6451 } 6451 }
6452 6452
6453 6453
6454 #undef __ 6454 #undef __
6455 6455
6456 } } // namespace v8::internal 6456 } } // namespace v8::internal
6457 6457
6458 #endif // V8_TARGET_ARCH_IA32 6458 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.cc ('k') | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698