Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Side by Side Diff: src/arm64/lithium-codegen-arm64.cc

Issue 167303005: Track field types. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/arm64/stub-cache-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5247 matching lines...) Expand 10 before | Expand all | Expand 10 after
5258 SmiCheck check_needed = instr->hydrogen()->value()->IsHeapObject() 5258 SmiCheck check_needed = instr->hydrogen()->value()->IsHeapObject()
5259 ? OMIT_SMI_CHECK : INLINE_SMI_CHECK; 5259 ? OMIT_SMI_CHECK : INLINE_SMI_CHECK;
5260 5260
5261 ASSERT(!(representation.IsSmi() && 5261 ASSERT(!(representation.IsSmi() &&
5262 instr->value()->IsConstantOperand() && 5262 instr->value()->IsConstantOperand() &&
5263 !IsInteger32Constant(LConstantOperand::cast(instr->value())))); 5263 !IsInteger32Constant(LConstantOperand::cast(instr->value()))));
5264 if (representation.IsHeapObject() && 5264 if (representation.IsHeapObject() &&
5265 !instr->hydrogen()->value()->type().IsHeapObject()) { 5265 !instr->hydrogen()->value()->type().IsHeapObject()) {
5266 DeoptimizeIfSmi(value, instr->environment()); 5266 DeoptimizeIfSmi(value, instr->environment());
5267 5267
5268 // We know that value is a smi now, so we can omit the check below. 5268 // We know now that value is not a smi, so we can omit the check below.
5269 check_needed = OMIT_SMI_CHECK; 5269 check_needed = OMIT_SMI_CHECK;
5270 } 5270 }
5271 5271
5272 if (!transition.is_null()) { 5272 if (!transition.is_null()) {
5273 // Store the new map value. 5273 // Store the new map value.
5274 Register new_map_value = ToRegister(instr->temp0()); 5274 Register new_map_value = ToRegister(instr->temp0());
5275 __ Mov(new_map_value, Operand(transition)); 5275 __ Mov(new_map_value, Operand(transition));
5276 __ Str(new_map_value, FieldMemOperand(object, HeapObject::kMapOffset)); 5276 __ Str(new_map_value, FieldMemOperand(object, HeapObject::kMapOffset));
5277 if (instr->hydrogen()->NeedsWriteBarrierForMap()) { 5277 if (instr->hydrogen()->NeedsWriteBarrierForMap()) {
5278 // Update the write barrier for the map field. 5278 // Update the write barrier for the map field.
(...skipping 648 matching lines...) Expand 10 before | Expand all | Expand 10 after
5927 __ Ldr(result, FieldMemOperand(object, JSObject::kPropertiesOffset)); 5927 __ Ldr(result, FieldMemOperand(object, JSObject::kPropertiesOffset));
5928 // Index is equal to negated out of object property index plus 1. 5928 // Index is equal to negated out of object property index plus 1.
5929 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2)); 5929 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2));
5930 __ Ldr(result, FieldMemOperand(result, 5930 __ Ldr(result, FieldMemOperand(result,
5931 FixedArray::kHeaderSize - kPointerSize)); 5931 FixedArray::kHeaderSize - kPointerSize));
5932 __ Bind(deferred->exit()); 5932 __ Bind(deferred->exit());
5933 __ Bind(&done); 5933 __ Bind(&done);
5934 } 5934 }
5935 5935
5936 } } // namespace v8::internal 5936 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/arm64/stub-cache-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698