Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 167303005: Track field types. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/stub-cache-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4093 matching lines...) Expand 10 before | Expand all | Expand 10 after
4104 4104
4105 ASSERT(!(representation.IsSmi() && 4105 ASSERT(!(representation.IsSmi() &&
4106 instr->value()->IsConstantOperand() && 4106 instr->value()->IsConstantOperand() &&
4107 !IsSmi(LConstantOperand::cast(instr->value())))); 4107 !IsSmi(LConstantOperand::cast(instr->value()))));
4108 if (representation.IsHeapObject()) { 4108 if (representation.IsHeapObject()) {
4109 Register value = ToRegister(instr->value()); 4109 Register value = ToRegister(instr->value());
4110 if (!instr->hydrogen()->value()->type().IsHeapObject()) { 4110 if (!instr->hydrogen()->value()->type().IsHeapObject()) {
4111 __ SmiTst(value); 4111 __ SmiTst(value);
4112 DeoptimizeIf(eq, instr->environment()); 4112 DeoptimizeIf(eq, instr->environment());
4113 4113
4114 // We know that value is a smi now, so we can omit the check below. 4114 // We know now that value is not a smi, so we can omit the check below.
4115 check_needed = OMIT_SMI_CHECK; 4115 check_needed = OMIT_SMI_CHECK;
4116 } 4116 }
4117 } else if (representation.IsDouble()) { 4117 } else if (representation.IsDouble()) {
4118 ASSERT(transition.is_null()); 4118 ASSERT(transition.is_null());
4119 ASSERT(access.IsInobject()); 4119 ASSERT(access.IsInobject());
4120 ASSERT(!instr->hydrogen()->NeedsWriteBarrier()); 4120 ASSERT(!instr->hydrogen()->NeedsWriteBarrier());
4121 DwVfpRegister value = ToDoubleRegister(instr->value()); 4121 DwVfpRegister value = ToDoubleRegister(instr->value());
4122 __ vstr(value, FieldMemOperand(object, offset)); 4122 __ vstr(value, FieldMemOperand(object, offset));
4123 return; 4123 return;
4124 } 4124 }
(...skipping 1739 matching lines...) Expand 10 before | Expand all | Expand 10 after
5864 __ ldr(result, FieldMemOperand(scratch, 5864 __ ldr(result, FieldMemOperand(scratch,
5865 FixedArray::kHeaderSize - kPointerSize)); 5865 FixedArray::kHeaderSize - kPointerSize));
5866 __ bind(deferred->exit()); 5866 __ bind(deferred->exit());
5867 __ bind(&done); 5867 __ bind(&done);
5868 } 5868 }
5869 5869
5870 5870
5871 #undef __ 5871 #undef __
5872 5872
5873 } } // namespace v8::internal 5873 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/arm/stub-cache-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698