Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: src/property.cc

Issue 167303005: Track field types. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Support transitions in LookupResult. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 #include "v8.h" 28 #include "types.h"
29 29
30 namespace v8 { 30 namespace v8 {
31 namespace internal { 31 namespace internal {
32 32
33 33
34 bool LookupResult::CanHoldValue(Handle<Object> value) const {
35 if (IsNormal()) return true;
36 if (!value->FitsRepresentation(details_.representation())) return false;
37 if (!IsField() && !IsTransition()) return true;
38 return HeapType::OfCurrently(value, isolate())->IsCurrently(GetFieldType());
39 }
40
41
34 void LookupResult::Iterate(ObjectVisitor* visitor) { 42 void LookupResult::Iterate(ObjectVisitor* visitor) {
35 LookupResult* current = this; // Could be NULL. 43 LookupResult* current = this; // Could be NULL.
36 while (current != NULL) { 44 while (current != NULL) {
37 visitor->VisitPointer(BitCast<Object**>(&current->holder_)); 45 visitor->VisitPointer(BitCast<Object**>(&current->holder_));
38 visitor->VisitPointer(BitCast<Object**>(&current->transition_)); 46 visitor->VisitPointer(BitCast<Object**>(&current->transition_));
39 current = current->next_; 47 current = current->next_;
40 } 48 }
41 } 49 }
42 50
43 51
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 PrintF(out, "Descriptor "); 120 PrintF(out, "Descriptor ");
113 GetKey()->ShortPrint(out); 121 GetKey()->ShortPrint(out);
114 PrintF(out, " @ "); 122 PrintF(out, " @ ");
115 GetValue()->ShortPrint(out); 123 GetValue()->ShortPrint(out);
116 } 124 }
117 125
118 126
119 #endif 127 #endif
120 128
121 129
130 HeapType* LookupResult::GetFieldTypeFromMap(Map* map) const {
131 ASSERT(IsFound());
132 ASSERT(IsField() || IsTransition());
133 return HeapType::cast(GetValueFromMap(map));
134 }
135
136
137 FieldDescriptor::FieldDescriptor(Name* key,
138 int field_index,
139 PropertyAttributes attributes,
140 Representation representation)
141 : Descriptor(key, HeapType::Any(), attributes, FIELD,
142 representation, field_index) {
143 }
144
145
146 FieldDescriptor::FieldDescriptor(Name* key,
147 int field_index,
148 HeapType* field_type,
149 PropertyAttributes attributes,
150 Representation representation)
151 : Descriptor(key, field_type, attributes, FIELD,
152 representation, field_index) {
153 }
154
155
122 } } // namespace v8::internal 156 } } // namespace v8::internal
OLDNEW
« src/property.h ('K') | « src/property.h ('k') | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698