Fix download danger prompt buttons/actions.

Fix download danger prompt buttons/actions.

- The default action should start as focused
- The default action should be on the right on Linux, left on CrOS/Win
- The default action in this case should be caution
- The default action should be worded positively ("Be safe" not "Cancel").

Unfortunately this means the UI/presentational concept of cancel/accept is inverted from the model's definition.

BUG=583244
Committed: https://crrev.com/bc8d9a61a0f09bedf0ac8d24182751e8a127a1ac
Cr-Commit-Position: refs/heads/master@{#374244}

[Evan Stade, 2016-02-06 02:02:16]

estade@chromium.org changed reviewers:
+ sky@chromium.org, wittman@chromium.org

[Evan Stade, 2016-02-06 02:02:16]

see bug for screenshots with this patch applied

[Evan Stade, 2016-02-06 02:02:23]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-06 02:03:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1672983002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1672983002/1

[Evan Stade, 2016-02-06 02:04:16]

Description was changed from

==========
Fix download danger prompt buttons/actions.

- The default action should start as focused
- The default action should be on the right on Linux, left on CrOS/Win
- The default action in this case should be caution
- The default action should be worded positively ("Be safe" not "Cancel").

BUG=583244
==========

to

==========
Fix download danger prompt buttons/actions.

- The default action should start as focused
- The default action should be on the right on Linux, left on CrOS/Win
- The default action in this case should be caution
- The default action should be worded positively ("Be safe" not "Cancel").

Unfortunately this means the UI/presentational concept of cancel/accept is
inverted from the model's definition.

BUG=583244
==========

[Evan Stade, 2016-02-06 02:04:21]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-06 02:05:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1672983002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1672983002/20001

[commit-bot: I haz the power, 2016-02-06 02:50:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-06 02:50:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mike Wittman, 2016-02-08 17:52:21]

lgtm % nit

https://codereview.chromium.org/1672983002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/download/download_danger_prompt_views.cc (right):

https://codereview.chromium.org/1672983002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/download/download_danger_prompt_views.cc:186: bool
DownloadDangerPromptViews::Accept() {
nit: declaration order has this below Cancel()

[sky, 2016-02-08 18:18:12]

LGTM

[Evan Stade, 2016-02-08 19:12:57]

https://codereview.chromium.org/1672983002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/download/download_danger_prompt_views.cc (right):

https://codereview.chromium.org/1672983002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/download/download_danger_prompt_views.cc:186: bool
DownloadDangerPromptViews::Accept() {
On 2016/02/08 17:52:21, Mike Wittman wrote:
> nit: declaration order has this below Cancel()

Done.

[Evan Stade, 2016-02-08 19:13:08]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-02-08 19:13:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
wittman@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1672983002/#ps40001
(title: "fix for tests")

[commit-bot: I haz the power, 2016-02-08 19:15:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1672983002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1672983002/40001

[commit-bot: I haz the power, 2016-02-08 19:42:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-08 19:42:06]

Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Evan Stade, 2016-02-09 00:18:30]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-02-09 00:24:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1672983002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1672983002/40001

[commit-bot: I haz the power, 2016-02-09 00:52:27]

Description was changed from

==========
Fix download danger prompt buttons/actions.

- The default action should start as focused
- The default action should be on the right on Linux, left on CrOS/Win
- The default action in this case should be caution
- The default action should be worded positively ("Be safe" not "Cancel").

Unfortunately this means the UI/presentational concept of cancel/accept is
inverted from the model's definition.

BUG=583244
==========

to

==========
Fix download danger prompt buttons/actions.

- The default action should start as focused
- The default action should be on the right on Linux, left on CrOS/Win
- The default action in this case should be caution
- The default action should be worded positively ("Be safe" not "Cancel").

Unfortunately this means the UI/presentational concept of cancel/accept is
inverted from the model's definition.

BUG=583244
==========

[commit-bot: I haz the power, 2016-02-09 00:52:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-09 00:54:15]

Description was changed from

==========
Fix download danger prompt buttons/actions.

- The default action should start as focused
- The default action should be on the right on Linux, left on CrOS/Win
- The default action in this case should be caution
- The default action should be worded positively ("Be safe" not "Cancel").

Unfortunately this means the UI/presentational concept of cancel/accept is
inverted from the model's definition.

BUG=583244
==========

to

==========
Fix download danger prompt buttons/actions.

- The default action should start as focused
- The default action should be on the right on Linux, left on CrOS/Win
- The default action in this case should be caution
- The default action should be worded positively ("Be safe" not "Cancel").

Unfortunately this means the UI/presentational concept of cancel/accept is
inverted from the model's definition.

BUG=583244

Committed: https://crrev.com/bc8d9a61a0f09bedf0ac8d24182751e8a127a1ac
Cr-Commit-Position: refs/heads/master@{#374244}
==========

[commit-bot: I haz the power, 2016-02-09 00:54:16]

Patchset 3 (id:??) landed as
https://crrev.com/bc8d9a61a0f09bedf0ac8d24182751e8a127a1ac
Cr-Commit-Position: refs/heads/master@{#374244}