third_party/WebKit/Source/platform/scroll/Scrollbar.cpp - Issue 1672973002: ScrollableArea::pixelsPerLine should return viewport pixels in use-zoom-for-dsf mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/Scrollbar.cpp

Issue 1672973002: ScrollableArea::pixelsPerLine should return viewport pixels in use-zoom-for-dsf mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/HostWindow.h ('K') | « third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp ('k') | third_party/WebKit/Source/web/ChromeClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/Scrollbar.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp b/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp

index f5e14e45c66cee83c8d06e636c59e1ed03dc317a..e48362a77bcc9b7c7ba798ff3c39d76bd24eb5c7 100644

--- a/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp

+++ b/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp

@@ -82,7 +82,7 @@ Scrollbar::Scrollbar(ScrollableArea* scrollableArea, ScrollbarOrientation orient

// alone when sizing).

int thickness = m_theme.scrollbarThickness(controlSize);

if (m_hostWindow)

- thickness = m_hostWindow->windowToViewport(FloatRect(0, 0, thickness, 0)).width();

+ thickness = m_hostWindow->windowToViewportScalar(thickness);

Widget::setFrameRect(IntRect(0, 0, thickness, thickness));

m_currentPos = scrollableAreaCurrentPos();

@@ -483,7 +483,7 @@ int Scrollbar::scrollbarThickness() const

int thickness = orientation() == HorizontalScrollbar ? height() : width();

if (!thickness || !m_hostWindow)

return thickness;

- return m_hostWindow->windowToViewport(FloatRect(0, 0, m_theme.scrollbarThickness(controlSize()), 0)).width();

+ return m_hostWindow->windowToViewportScalar(m_theme.scrollbarThickness(controlSize()));

}