ScrollableArea::pixelsPerLine should return viewport pixels in use-zoom-for-dsf mode

third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

 /*
  * Copyright (c) 2010, Google Inc. All rights reserved.
  * Copyright (C) 2008, 2011 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 42 matching lines @@
 #if ENABLE(ASSERT) && ENABLE(OILPAN)
     VerifyEagerFinalization verifyEager;
 #endif
     OwnPtrWillBeMember<void*> pointer[2];
     unsigned bitfields : 16;
     IntPoint origin;
 };
 
 static_assert(sizeof(ScrollableArea) == sizeof(SameSizeAsScrollableArea), "ScrollableArea should stay small");
 
-int ScrollableArea::pixelsPerLineStep()
+int ScrollableArea::pixelsPerLineStep(HostWindow* host)
 {
-    return kPixelsPerLineStep;
+    if (!host)
+        return kPixelsPerLineStep;
+    FloatRect tmpRectInViewport = host->windowToViewport(FloatRect(1, 0, 0, 0));
+    return kPixelsPerLineStep * tmpRectInViewport.x();
 }
 
 float ScrollableArea::minFractionToStepWhenPaging()
 {
     return kMinFractionToStepWhenPaging;
 }
 
 int ScrollableArea::maxOverlapBetweenPages()
 {
     static int maxOverlapBetweenPages = ScrollbarTheme::theme().maxOverlapBetweenPages();
@@ skipping 483 matching lines @@
     return scrollPosition.shrunkTo(maximumScrollPosition()).expandedTo(minimumScrollPosition());
 }
 
 DoublePoint ScrollableArea::clampScrollPosition(const DoublePoint& scrollPosition) const
 {
     return scrollPosition.shrunkTo(maximumScrollPositionDouble()).expandedTo(minimumScrollPositionDouble());
 }
 
 int ScrollableArea::lineStep(ScrollbarOrientation) const
 {
-    return pixelsPerLineStep();
+    return pixelsPerLineStep(hostWindow());
 }
 
 int ScrollableArea::pageStep(ScrollbarOrientation orientation) const
 {
     IntRect visibleRect = visibleContentRect(IncludeScrollbars);
     int length = (orientation == HorizontalScrollbar) ? visibleRect.width() : visibleRect.height();
     int minPageStep = static_cast<float>(length) * minFractionToStepWhenPaging();
     int pageStep = std::max(minPageStep, length - maxOverlapBetweenPages());
 
     return std::max(pageStep, 1);
 }
 
 int ScrollableArea::documentStep(ScrollbarOrientation orientation) const
 {
     return scrollSize(orientation);
 }
 
 float ScrollableArea::pixelStep(ScrollbarOrientation) const
 {
     return 1;

[oshima, 2016/02/09 02:05:02]

Looks like this is DIP, but I'm not sure converting to viewport pixels is the
right thing here. skobes@, should I keep this as is or should I convert this as
well?

[skobes, 2016/02/09 18:36:06]

As far as I know ScrollableArea only deals in DIPs, not physical pixels.  What
is the reason for this change?

[oshima, 2016/02/09 23:15:07]

In use-zoom-for-dsf mode, the viewport pixel becomes DIP* device scale factor.
The arrow scroll for exmaple becomes 2x slower because it only moves half
without these changes.

 }
 
 IntSize ScrollableArea::excludeScrollbars(const IntSize& size) const
 {
     int verticalScrollbarWidth = 0;
     int horizontalScrollbarHeight = 0;
 
     if (Scrollbar* verticalBar = verticalScrollbar())
         verticalScrollbarWidth = !verticalBar->isOverlayScrollbar() ? verticalBar->width() : 0;
     if (Scrollbar* horizontalBar = horizontalScrollbar())
         horizontalScrollbarHeight = !horizontalBar->isOverlayScrollbar() ? horizontalBar->height() : 0;
 
     return IntSize(std::max(0, size.width() - verticalScrollbarWidth),
         std::max(0, size.height() - horizontalScrollbarHeight));
 }
 
 DEFINE_TRACE(ScrollableArea)
 {
     visitor->trace(m_scrollAnimator);
     visitor->trace(m_programmaticScrollAnimator);
 }
 
 } // namespace blink