Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 167293003: Remove unused ResourceLoaderOptions functionality. (Closed)

Created:
6 years, 10 months ago by sof
Modified:
6 years, 10 months ago
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove unused ResourceLoaderOptions functionality. Retire the enumerations ClientCrossOriginCredentialPolicy and SecurityCheckPolicy, and their storage on the resource loader options struct. Neither is made use of during resource loading. The propagation of a SecurityCheckPolicy setting when issuing a load request by the 'threadable' document loaders is as a result also no longer done. R= BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167237

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -30 lines) Patch
M Source/core/fetch/ResourceFetcher.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/fetch/ResourceLoaderOptions.h View 4 chunks +0 lines, -18 lines 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentThreadableLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentThreadableLoader.cpp View 4 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sof
When you have a moment, please take a look.
6 years, 10 months ago (2014-02-14 19:05:42 UTC) #1
sof
When you have a moment, please take a look.
6 years, 10 months ago (2014-02-14 19:06:17 UTC) #2
Nate Chapin
lgtm
6 years, 10 months ago (2014-02-14 19:09:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/167293003/1
6 years, 10 months ago (2014-02-14 19:09:09 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 22:55:47 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=12511
6 years, 10 months ago (2014-02-14 22:55:48 UTC) #6
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 10 months ago (2014-02-15 06:15:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/167293003/1
6 years, 10 months ago (2014-02-15 06:15:12 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-15 18:33:12 UTC) #9
Message was sent while issue was closed.
Change committed as 167237

Powered by Google App Engine
This is Rietveld 408576698