Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Issue 1672863002: bluetooth: Add Layout Test for unique origin. (Closed)

Created:
4 years, 10 months ago by ortuno
Modified:
4 years, 10 months ago
Reviewers:
Jeffrey Yasskin
CC:
blink-reviews, chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@my-origin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Add Layout Test for unique origin. Eventually sandboxed iframes may be explicitly granted the right to request permissions but for now we block any Bluetooth requests from sandboxed iframes. BUG=579691 Committed: https://crrev.com/1fe10a94e641fa30d6c06b02c751c43a964668eb Cr-Commit-Position: refs/heads/master@{#374804}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment about 'Go' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/bluetooth/requestDevice-sandboxed-iframe.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/resources/requestDevice-in-sandboxed-iframe.html View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1672863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1672863002/1
4 years, 10 months ago (2016-02-09 00:31:02 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-09 01:50:24 UTC) #4
ortuno
jyasskin: PTAL
4 years, 10 months ago (2016-02-10 22:08:31 UTC) #6
Jeffrey Yasskin
LGTM. Thanks! https://codereview.chromium.org/1672863002/diff/1/third_party/WebKit/LayoutTests/bluetooth/resources/requestDevice-in-sandboxed-iframe.html File third_party/WebKit/LayoutTests/bluetooth/resources/requestDevice-in-sandboxed-iframe.html (right): https://codereview.chromium.org/1672863002/diff/1/third_party/WebKit/LayoutTests/bluetooth/resources/requestDevice-in-sandboxed-iframe.html#newcode5 third_party/WebKit/LayoutTests/bluetooth/resources/requestDevice-in-sandboxed-iframe.html:5: if (messageEvent.data === 'Go') { Comment that ...
4 years, 10 months ago (2016-02-10 22:26:11 UTC) #8
ortuno
https://codereview.chromium.org/1672863002/diff/1/third_party/WebKit/LayoutTests/bluetooth/resources/requestDevice-in-sandboxed-iframe.html File third_party/WebKit/LayoutTests/bluetooth/resources/requestDevice-in-sandboxed-iframe.html (right): https://codereview.chromium.org/1672863002/diff/1/third_party/WebKit/LayoutTests/bluetooth/resources/requestDevice-in-sandboxed-iframe.html#newcode5 third_party/WebKit/LayoutTests/bluetooth/resources/requestDevice-in-sandboxed-iframe.html:5: if (messageEvent.data === 'Go') { On 2016/02/10 at 22:26:11, ...
4 years, 10 months ago (2016-02-10 23:09:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1672863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1672863002/20001
4 years, 10 months ago (2016-02-10 23:11:04 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-11 00:37:36 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:33:13 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1fe10a94e641fa30d6c06b02c751c43a964668eb
Cr-Commit-Position: refs/heads/master@{#374804}

Powered by Google App Engine
This is Rietveld 408576698