Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: runtime/vm/message_handler.cc

Issue 1672853002: Move sticky_error_ from isolate to thread (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Comments addressed Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/longjump.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/message_handler.h" 5 #include "vm/message_handler.h"
6 6
7 #include "vm/dart.h" 7 #include "vm/dart.h"
8 #include "vm/lockers.h" 8 #include "vm/lockers.h"
9 #include "vm/object.h" 9 #include "vm/object.h"
10 #include "vm/object_store.h" 10 #include "vm/object_store.h"
(...skipping 364 matching lines...) Expand 10 before | Expand all | Expand 10 after
375 // Still paused. 375 // Still paused.
376 ASSERT(oob_queue_->IsEmpty()); 376 ASSERT(oob_queue_->IsEmpty());
377 task_ = NULL; // No task in queue. 377 task_ = NULL; // No task in queue.
378 return; 378 return;
379 } else { 379 } else {
380 PausedOnExitLocked(false); 380 PausedOnExitLocked(false);
381 } 381 }
382 } 382 }
383 if (FLAG_trace_isolates) { 383 if (FLAG_trace_isolates) {
384 if (status != kOK && isolate() != NULL) { 384 if (status != kOK && isolate() != NULL) {
385 const Error& error = 385 const Error& error = Error::Handle(thread()->sticky_error());
386 Error::Handle(isolate()->object_store()->sticky_error());
387 OS::Print("[-] Stopping message handler (%s):\n" 386 OS::Print("[-] Stopping message handler (%s):\n"
388 "\thandler: %s\n" 387 "\thandler: %s\n"
389 "\terror: %s\n", 388 "\terror: %s\n",
390 MessageStatusString(status), name(), error.ToCString()); 389 MessageStatusString(status), name(), error.ToCString());
391 } else { 390 } else {
392 OS::Print("[-] Stopping message handler (%s):\n" 391 OS::Print("[-] Stopping message handler (%s):\n"
393 "\thandler: %s\n", 392 "\thandler: %s\n",
394 MessageStatusString(status), name()); 393 MessageStatusString(status), name());
395 } 394 }
396 } 395 }
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
548 547
549 548
550 void MessageHandler::AcquireQueues(AcquiredQueues* acquired_queues) { 549 void MessageHandler::AcquireQueues(AcquiredQueues* acquired_queues) {
551 ASSERT(acquired_queues != NULL); 550 ASSERT(acquired_queues != NULL);
552 // No double dipping. 551 // No double dipping.
553 ASSERT(acquired_queues->handler_ == NULL); 552 ASSERT(acquired_queues->handler_ == NULL);
554 acquired_queues->Reset(this); 553 acquired_queues->Reset(this);
555 } 554 }
556 555
557 } // namespace dart 556 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/longjump.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698