Implement fake Bluetooth adapter for BluetoothTest.ConstructFakeAdapter

Implement fake Bluetooth adapter for BluetoothTest.ConstructFakeAdapter

This CL implements fake Bluetooth adapter for BluetoothTest.ConstructFakeAdapter test.

BUG=579202
Committed: https://crrev.com/30b814166d2bce701ca589534829ef5fa195203a
Cr-Commit-Position: refs/heads/master@{#374150}

[gogerald1, 2016-02-05 21:02:19]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-05 21:04:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1672843002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1672843002/1

[gogerald1, 2016-02-05 21:08:44]

Description was changed from

==========
format


rename


add fake adapter

BUG=
==========

to

==========
Implement fake Bluetooth adapter for BluetoothTest.ConstructFakeAdapter

This CL implements fake Bluetooth adapter for BluetoothTest.ConstructFakeAdapter
test.

BUG=579202
==========

[gogerald1, 2016-02-05 21:43:06]

Patchset #2 (id:20001) has been deleted

[gogerald1, 2016-02-05 21:46:12]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[gogerald1, 2016-02-05 21:46:41]

gogerald@chromium.org changed reviewers:
+ scheib@chromium.org

[gogerald1, 2016-02-05 21:46:41]

Hi Vincent, PTAL.

[commit-bot: I haz the power, 2016-02-05 21:48:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1672843002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1672843002/40001

[commit-bot: I haz the power, 2016-02-05 23:52:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-05 23:52:59]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)

[gogerald1, 2016-02-06 20:12:31]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-06 20:12:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1672843002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1672843002/60001

[scheib, 2016-02-07 01:45:19]

https://codereview.chromium.org/1672843002/diff/60001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_classic_win.cc (right):

https://codereview.chromium.org/1672843002/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_classic_win.cc:42: if
(opened_radio_handle_.IsValid())
.Set() performs Close (and in that, IsValid). So just .Set needed here I think.

https://codereview.chromium.org/1672843002/diff/60001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_classic_win_fake.cc (right):

https://codereview.chromium.org/1672843002/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_classic_win_fake.cc:18: if (simulated_radios_.get()
!= nullptr) {
Just:
if (simulated_radios_) {

https://codereview.chromium.org/1672843002/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_classic_win_fake.cc:28: if (simulated_radios_.get()
!= nullptr) {
Just:
if (simulated_radios_) {

https://codereview.chromium.org/1672843002/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_classic_win_fake.cc:31: return ERROR_SUCCESS;
Return success even if there were no radios?

https://codereview.chromium.org/1672843002/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_classic_win_fake.cc:39: if (simulated_radios_.get()
!= nullptr) {
Just:
if (simulated_radios_) {

https://codereview.chromium.org/1672843002/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_classic_win_fake.cc:42: return TRUE;
If no radios it seems that FALSE should be returned?

https://codereview.chromium.org/1672843002/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_classic_win_fake.cc:82: for (size_t i = 0; i <
length; i++) {
There is very likely a src/base utility for this, most likely:
vswprintf in src/base/strings/string_util_win.h.

https://codereview.chromium.org/1672843002/diff/60001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_classic_win_fake.h (right):

https://codereview.chromium.org/1672843002/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_classic_win_fake.h:47: scoped_ptr<BluetoothRadio>
simulated_radios_;
Seems there's only ever one radio possible, so just 'simulated_radio_'?

[commit-bot: I haz the power, 2016-02-07 04:28:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-07 04:28:12]

Dry run: This issue passed the CQ dry run.

[gogerald1, 2016-02-08 16:56:19]

Patchset #4 (id:80001) has been deleted

[gogerald1, 2016-02-08 16:56:51]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-08 16:58:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1672843002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1672843002/100001

[gogerald1, 2016-02-08 17:00:05]

https://codereview.chromium.org/1672843002/diff/60001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_classic_win.cc (right):

https://codereview.chromium.org/1672843002/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_classic_win.cc:42: if
(opened_radio_handle_.IsValid())
On 2016/02/07 01:45:18, scheib wrote:
> .Set() performs Close (and in that, IsValid). So just .Set needed here I
think.

Done.

https://codereview.chromium.org/1672843002/diff/60001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_classic_win_fake.cc (right):

https://codereview.chromium.org/1672843002/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_classic_win_fake.cc:18: if (simulated_radios_.get()
!= nullptr) {
On 2016/02/07 01:45:19, scheib wrote:
> Just:
> if (simulated_radios_) {

Done.

https://codereview.chromium.org/1672843002/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_classic_win_fake.cc:28: if (simulated_radios_.get()
!= nullptr) {
On 2016/02/07 01:45:18, scheib wrote:
> Just:
> if (simulated_radios_) {

Done.

https://codereview.chromium.org/1672843002/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_classic_win_fake.cc:31: return ERROR_SUCCESS;
On 2016/02/07 01:45:18, scheib wrote:
> Return success even if there were no radios?

Done. Move error record from next CL to this CL.

https://codereview.chromium.org/1672843002/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_classic_win_fake.cc:39: if (simulated_radios_.get()
!= nullptr) {
On 2016/02/07 01:45:18, scheib wrote:
> Just:
> if (simulated_radios_) {

Done.

https://codereview.chromium.org/1672843002/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_classic_win_fake.cc:42: return TRUE;
On 2016/02/07 01:45:19, scheib wrote:
> If no radios it seems that FALSE should be returned? 

Done.

https://codereview.chromium.org/1672843002/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_classic_win_fake.cc:82: for (size_t i = 0; i <
length; i++) {
On 2016/02/07 01:45:19, scheib wrote:
> There is very likely a src/base utility for this, most likely:
> vswprintf in src/base/strings/string_util_win.h.

It looks this function is used to write formatted data from variable argument
list (va_list) to sized buffer, but not string16 input. Instead I use wcsncpy to
make it look neat.

https://codereview.chromium.org/1672843002/diff/60001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_classic_win_fake.h (right):

https://codereview.chromium.org/1672843002/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_classic_win_fake.h:47: scoped_ptr<BluetoothRadio>
simulated_radios_;
On 2016/02/07 01:45:19, scheib wrote:
> Seems there's only ever one radio possible, so just 'simulated_radio_'?

Yes, so as in BluetoothTaskManager, we could extend it in the future when
necessary.

[commit-bot: I haz the power, 2016-02-08 18:22:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-08 18:22:08]

Dry run: This issue passed the CQ dry run.

[scheib, 2016-02-08 18:31:35]

LGTM

[gogerald1, 2016-02-08 18:36:25]

The CQ bit was checked by gogerald@chromium.org

[commit-bot: I haz the power, 2016-02-08 18:39:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1672843002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1672843002/100001

[commit-bot: I haz the power, 2016-02-08 18:52:41]

Description was changed from

==========
Implement fake Bluetooth adapter for BluetoothTest.ConstructFakeAdapter

This CL implements fake Bluetooth adapter for BluetoothTest.ConstructFakeAdapter
test.

BUG=579202
==========

to

==========
Implement fake Bluetooth adapter for BluetoothTest.ConstructFakeAdapter

This CL implements fake Bluetooth adapter for BluetoothTest.ConstructFakeAdapter
test.

BUG=579202
==========

[commit-bot: I haz the power, 2016-02-08 18:52:41]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-02-08 18:53:56]

Description was changed from

==========
Implement fake Bluetooth adapter for BluetoothTest.ConstructFakeAdapter

This CL implements fake Bluetooth adapter for BluetoothTest.ConstructFakeAdapter
test.

BUG=579202
==========

to

==========
Implement fake Bluetooth adapter for BluetoothTest.ConstructFakeAdapter

This CL implements fake Bluetooth adapter for BluetoothTest.ConstructFakeAdapter
test.

BUG=579202

Committed: https://crrev.com/30b814166d2bce701ca589534829ef5fa195203a
Cr-Commit-Position: refs/heads/master@{#374150}
==========

[commit-bot: I haz the power, 2016-02-08 18:53:57]

Patchset 4 (id:??) landed as
https://crrev.com/30b814166d2bce701ca589534829ef5fa195203a
Cr-Commit-Position: refs/heads/master@{#374150}