common/logdog/coordinator/stream_params.go - Issue 1672833003: LogDog: Add log rendering view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: common/logdog/coordinator/stream_params.go

Issue 1672833003: LogDog: Add log rendering view. Base URL: https://github.com/luci/luci-go@master

Patch Set: Clean up, add tests, little reorg. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: common/logdog/coordinator/stream_params.go

diff --git a/common/logdog/coordinator/stream_params.go b/common/logdog/coordinator/stream_params.go

index 9642278045dd081d0d3ba186e4211511f1e4b0a5..c2ed3895c71376d344743cba72a0a0c89fbe0786 100644

--- a/common/logdog/coordinator/stream_params.go

+++ b/common/logdog/coordinator/stream_params.go

@@ -41,7 +41,7 @@ func (p *StreamGetParams) Index(i types.MessageIndex) *StreamGetParams {

// Limit limits the returned logs either by count or by byte count. If either

// limit is <= 0, then no limit will be applied and the server will choose how

// many logs to return.

-func (p *StreamGetParams) Limit(bytes, count int) *StreamGetParams {

+func (p *StreamGetParams) Limit(bytes, count int32) *StreamGetParams {

p = p.clone()

if bytes < 0 {

@@ -51,7 +51,7 @@ func (p *StreamGetParams) Limit(bytes, count int) *StreamGetParams {

count = 0

}

- p.r.ByteCount, p.r.LogCount = int32(bytes), int32(count)

+ p.r.ByteCount, p.r.LogCount = bytes, count

return p

}

« no previous file with comments | « client/cmd/logdog_cat/coordinatorSource.go ('k') | common/logdog/fetcher/fetcher.go » ('j') | no next file with comments »