Issue 1672773002: Revert "Added a switch to dump minidump modules in minidump_stackwalk."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1672773002: Revert "Added a switch to dump minidump modules in minidump_stackwalk." (Closed)

Created:
4 years, 10 months ago by David Yen

Modified:
4 years, 10 months ago

Reviewers:
Lei Zhang

CC:
google-breakpad-dev_googlegroups.com

Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Revert "Added a switch to dump minidump modules in minidump_stackwalk." This reverts commit cb936a0243c97ae9cd2d4bb19d95dde0421fed6d. The changes made here are not necessary, using the minidump_dump executable which already exists gives all the necessary information. R=thestig@chromium.org BUG=563716

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -30 lines)			Patch
M	src/processor/minidump_stackwalk.cc	View	6 chunks	+5 lines, -20 lines	0 comments	Download
M	src/processor/stackwalk_common.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/processor/stackwalk_common.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

David Yen

On 2016/02/06 00:06:21, Lei Zhang wrote: > lgtm I'm not a committer, can you land ...

4 years, 10 months ago (2016-02-06 00:44:50 UTC) #3

Lei Zhang

4 years, 10 months ago (2016-02-10 20:54:43 UTC) #4

On 2016/02/06 00:44:50, David Yen wrote:
> On 2016/02/06 00:06:21, Lei Zhang wrote:
> > lgtm
> 
> I'm not a committer, can you land this for me?

CL for landing: https://codereview.chromium.org/1688493003/

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages