Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1672753002: Generate spec.sum and strong.sum summaties for SDK. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Generate spec.sum and strong.sum summaties for SDK. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e43fc7e4ef06211a6f81bc051194e626ab75d730

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use the word 'build' instead of 'generate'. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -103 lines) Patch
A + pkg/analyzer/tool/summary/build_sdk_summaries.dart View 1 5 chunks +34 lines, -13 lines 0 comments Download
D pkg/analyzer/tool/summary/build_sdk_summary.dart View 1 chunk +0 lines, -90 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 10 months ago (2016-02-05 16:50:15 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/1672753002/diff/1/pkg/analyzer/tool/summary/build_sdk_summaries.dart File pkg/analyzer/tool/summary/build_sdk_summaries.dart (right): https://codereview.chromium.org/1672753002/diff/1/pkg/analyzer/tool/summary/build_sdk_summaries.dart#newcode61 pkg/analyzer/tool/summary/build_sdk_summaries.dart:61: print('Generating ${strongMode ? 'strong' : 'spec'} mode summary.'); ...
4 years, 10 months ago (2016-02-05 16:53:26 UTC) #2
scheglov
4 years, 10 months ago (2016-02-05 17:00:59 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
e43fc7e4ef06211a6f81bc051194e626ab75d730 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698