|
Revert 251382 "event-rewrite: Clean up how events are rewritten."
> event-rewrite: Clean up how events are rewritten.
>
> Notable changes:
> * Make the EventRewriter a MessagePumpObserver. This is necessary to make sure
> that the event-rewrite happens before the event is dispatched.
> * Move the EventRewriter in chrome/browser/chromeos (and in chromeos namespace),
> since it does nothing on other platforms.
> * Get rid of the event-rewrite code from ash, since it just adds an extra layer
> of abstraction for no added value.
>
> BUG= 343639
> R=derat@chromium.org, sky@chromium.org, stevenjb@chromium.org
>
> Review URL: https://codereview.chromium.org/165463002
This was causing the following check failure
[3943:3943:0214/135331:FATAL:event_rewriter.cc(858)] Check failed:
xievent->evtype == XI_ButtonPress || xievent->evtype == XI_ButtonRelease.
Aborted (core dumped)
TBR=sadrul@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251433
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+47 lines, -3608 lines) |
Patch |
 |
M |
trunk/src/ash/accelerators/accelerator_dispatcher.cc
|
View
|
|
2 chunks |
+10 lines, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/ash/ash.gyp
|
View
|
|
2 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/ash/event_rewriter_delegate.h
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
M |
trunk/src/ash/shell.h
|
View
|
|
2 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/ash/shell.cc
|
View
|
|
3 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/ash/wm/event_rewriter_event_filter.h
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/ash/wm/event_rewriter_event_filter.cc
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chromeos/accessibility/accessibility_manager.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chromeos/chrome_browser_main_chromeos.h
|
View
|
|
2 chunks |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
|
View
|
|
3 chunks |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/chromeos/event_rewriter.h
|
View
|
|
1 chunk |
+0 lines, -214 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/chromeos/event_rewriter.cc
|
View
|
|
1 chunk |
+0 lines, -907 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/chromeos/event_rewriter_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -2465 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chromeos/keyboard_driven_event_rewriter.h
|
View
|
|
2 chunks |
+6 lines, -4 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chromeos/keyboard_driven_event_rewriter.cc
|
View
|
|
2 chunks |
+15 lines, -14 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chromeos/keyboard_driven_event_rewriter_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/ui/ash/ash_init.cc
|
View
|
|
2 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/ui/ash/event_rewriter.h
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/ui/ash/event_rewriter.cc
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/ui/ash/event_rewriter_unittest.cc
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/chrome_browser_chromeos.gypi
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/chrome_browser_ui.gypi
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/chrome_tests_unit.gypi
|
View
|
|
2 chunks |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|