Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1672663002: Access generated resources through full path for better DEPS. (Closed)

Created:
4 years, 10 months ago by sdefresne
Modified:
4 years, 10 months ago
Reviewers:
droger, oshima
CC:
chromium-reviews, mlamouri+watch-geolocation_chromium.org, Michael van Ouwerkerk, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Access generated resources through full path for better DEPS. TBR=oshima@chromium.org BUG=None Committed: https://crrev.com/365797837ff23cfdceb707aad92b92e6cea3a0d0 Cr-Commit-Position: refs/heads/master@{#373785}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -37 lines) Patch
M ios/chrome/browser/DEPS View 1 chunk +2 lines, -5 lines 0 comments Download
M ios/chrome/browser/about_flags.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/geolocation/omnibox_geolocation_authorization_alert.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/interstitials/ios_security_interstitial_page.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/translate/after_translate_infobar_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/translate/before_translate_infobar_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/translate/never_translate_infobar_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/about_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/crashes_ui.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/webui/flags_ui.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/webui/gcm/gcm_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/history/browsing_history_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/history/history_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/webui/net_export/net_export_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/sync_internals/sync_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/version_ui.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ios/web/webui/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/webui/shared_resources_data_source_ios.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
sdefresne
Please take a look.
4 years, 10 months ago (2016-02-05 09:59:58 UTC) #2
droger
lgtm
4 years, 10 months ago (2016-02-05 10:05:07 UTC) #3
sdefresne
TBR-ing oshima for DEPS on ui/resources/grit since the resources was already there (as grit/ui_resources.h).
4 years, 10 months ago (2016-02-05 10:07:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1672663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1672663002/1
4 years, 10 months ago (2016-02-05 10:08:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-05 11:08:32 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 11:10:11 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/365797837ff23cfdceb707aad92b92e6cea3a0d0
Cr-Commit-Position: refs/heads/master@{#373785}

Powered by Google App Engine
This is Rietveld 408576698