Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1672573002: Eliminate ScopedVector in components/omnibox. (Closed)

Created:
4 years, 10 months ago by Peter Kasting
Modified:
4 years, 10 months ago
Reviewers:
Mark P
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate ScopedVector in components/omnibox. BUG=554289 TEST=none Committed: https://crrev.com/c2f751a8d37618dc8a2afff306d4da1076c250b4 Cr-Commit-Position: refs/heads/master@{#374603}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Don't use C++14 stuff #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M components/omnibox/browser/base_search_provider.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/omnibox/browser/base_search_provider.cc View 1 2 chunks +7 lines, -6 lines 1 comment Download

Messages

Total messages: 12 (5 generated)
Peter Kasting
https://codereview.chromium.org/1672573002/diff/1/components/omnibox/browser/base_search_provider.cc File components/omnibox/browser/base_search_provider.cc (right): https://codereview.chromium.org/1672573002/diff/1/components/omnibox/browser/base_search_provider.cc#newcode487 components/omnibox/browser/base_search_provider.cc:487: [handler](const auto& elem) { return elem.get() == handler; })); ...
4 years, 10 months ago (2016-02-05 00:54:04 UTC) #2
Mark P
lgtm https://codereview.chromium.org/1672573002/diff/20001/components/omnibox/browser/base_search_provider.cc File components/omnibox/browser/base_search_provider.cc (right): https://codereview.chromium.org/1672573002/diff/20001/components/omnibox/browser/base_search_provider.cc#newcode487 components/omnibox/browser/base_search_provider.cc:487: [handler](const scoped_ptr<SuggestionDeletionHandler>& elem) { Ah, how the language ...
4 years, 10 months ago (2016-02-05 19:19:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1672573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1672573002/20001
4 years, 10 months ago (2016-02-06 01:45:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/19361)
4 years, 10 months ago (2016-02-06 02:28:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1672573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1672573002/20001
4 years, 10 months ago (2016-02-10 02:36:06 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-10 04:29:40 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 04:31:45 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c2f751a8d37618dc8a2afff306d4da1076c250b4
Cr-Commit-Position: refs/heads/master@{#374603}

Powered by Google App Engine
This is Rietveld 408576698