e2e test for transformer (webdriver + pub serve)

e2e test for transformer (webdriver + pub serve)

BUG=
R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/3f6c7b2c15fd43f39f91b35101e96dffd24b4fd7

[ochafik, 2016-02-11 18:04:13]

Description was changed from

==========
e2e test for transformer (webdriver + pub serve)

BUG=
==========

to

==========
e2e test for transformer (webdriver + pub serve)

Disabled in Travis b/c seems problematic to spawn servers, but runs just fine
locally.

BUG=
==========

[ochafik, 2016-02-11 18:08:21]

ochafik@google.com changed reviewers:
+ rnystrom@google.com, vsm@google.com

[ochafik, 2016-02-11 18:08:21]

Hey guys, here's a small e2e test that spawns a webdriver, pub serves with the
transformer, and checks that hello world is displayed on the page.

That said... just let me know if you think it's overkill :-)

[vsm, 2016-02-11 18:15:02]

On 2016/02/11 18:08:21, ochafik wrote:
> Hey guys, here's a small e2e test that spawns a webdriver, pub serves with the
> transformer, and checks that hello world is displayed on the page.
> 
> That said... just let me know if you think it's overkill :-)

Nice!

FWIW, the Angular folks appear to run Webdriver on Travis.  Here's a PR from
Yegor to add a DDC e2e test:

https://github.com/angular/angular/pull/6783

[vsm, 2016-02-12 14:41:50]

lgtm

https://codereview.chromium.org/1672563002/diff/140001/test/transformer_e2e_t...
File test/transformer_e2e_test.dart (right):

https://codereview.chromium.org/1672563002/diff/140001/test/transformer_e2e_t...
test/transformer_e2e_test.dart:42: 'args': ['--no-sandbox',
'--js-flags=--harmony'],
Shouldn't need --harmony flags any more.

[ochafik, 2016-02-12 14:41:53]

Description was changed from

==========
e2e test for transformer (webdriver + pub serve)

Disabled in Travis b/c seems problematic to spawn servers, but runs just fine
locally.

BUG=
==========

to

==========
e2e test for transformer (webdriver + pub serve)

BUG=
==========

[ochafik, 2016-02-12 14:51:32]

On 2016/02/11 18:15:02, vsm wrote:
> On 2016/02/11 18:08:21, ochafik wrote: 
> FWIW, the Angular folks appear to run Webdriver on Travis.  Here's a PR from
> Yegor to add a DDC e2e test:
> 
> https://github.com/angular/angular/pull/6783

It's really cool they set this up! (maybe they'll be able to simplify their
setup with the transformer now, too)

This will be complementary / DDC-focused / non-angular-specific.

[ochafik, 2016-02-12 14:52:22]

Thanks Vijay!

https://codereview.chromium.org/1672563002/diff/140001/test/transformer_e2e_t...
File test/transformer_e2e_test.dart (right):

https://codereview.chromium.org/1672563002/diff/140001/test/transformer_e2e_t...
test/transformer_e2e_test.dart:42: 'args': ['--no-sandbox',
'--js-flags=--harmony'],
On 2016/02/12 14:41:49, vsm wrote:
> Shouldn't need --harmony flags any more.

Thanks, indeed!

[ochafik, 2016-02-12 14:53:20]

Description was changed from

==========
e2e test for transformer (webdriver + pub serve)

BUG=
==========

to

==========
e2e test for transformer (webdriver + pub serve)

BUG=
R=vsm@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/3f6c7b2c15fd43f39f91b35101e9...
==========

[ochafik, 2016-02-12 14:53:22]

Committed patchset #11 (id:200001) manually as
3f6c7b2c15fd43f39f91b35101e96dffd24b4fd7 (presubmit successful).