Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1077)

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

Issue 1672553004: Use FontFallbackPriority Fonts in FontFallbackIterator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Column limit Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
index e4c1adc78ae931f044c7bde788a2ac5dd2880b6d..4c1a009432b9a7dd31d87a67f05fa5c53cb92155 100644
--- a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
+++ b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
@@ -536,7 +536,8 @@ PassRefPtr<ShapeResult> HarfBuzzShaper::shapeResult()
0,
USCRIPT_INVALID_CODE,
OrientationIterator::OrientationInvalid,
- SmallCapsIterator::SmallCapsSameCase };
+ SmallCapsIterator::SmallCapsSameCase,
+ FontFallbackPriority::Invalid };
RunSegmenter runSegmenter(
m_normalizedBuffer.get(),
m_normalizedBufferLength,
@@ -548,7 +549,9 @@ PassRefPtr<ShapeResult> HarfBuzzShaper::shapeResult()
// TODO: Check whether this treatAsZerowidthspace from the previous script
// segmentation plays a role here, does the new scriptRuniterator handle that correctly?
while (runSegmenter.consume(&segmentRange)) {
- RefPtr<FontFallbackIterator> fallbackIterator = m_font->createFontFallbackIterator();
+ RefPtr<FontFallbackIterator> fallbackIterator =
+ m_font->createFontFallbackIterator(
+ segmentRange.fontFallbackPriority);
appendToHolesQueue(HolesQueueNextFont, 0, 0);
appendToHolesQueue(HolesQueueRange, segmentRange.start, segmentRange.end - segmentRange.start);

Powered by Google App Engine
This is Rietveld 408576698