Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3202)

Unified Diff: build/android/devil/android/battery_utils_test.py

Issue 1672543002: [Android] Detect if device is not charging properly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/devil/android/battery_utils_test.py
diff --git a/build/android/devil/android/battery_utils_test.py b/build/android/devil/android/battery_utils_test.py
index 734b68d1b20f00ec4de17b1b45a7b07a747c6e28..832b8163e0a8ffaf3575d8ffd2e74fcaa37ce25d 100755
--- a/build/android/devil/android/battery_utils_test.py
+++ b/build/android/devil/android/battery_utils_test.py
@@ -244,13 +244,37 @@ class BatteryUtilsGetPowerData(BatteryUtilsTest):
class BatteryUtilsChargeDevice(BatteryUtilsTest):
@mock.patch('time.sleep', mock.Mock())
- def testChargeDeviceToLevel(self):
+ def testChargeDeviceToLevel_pass(self):
with self.assertCalls(
(self.call.battery.SetCharging(True)),
(self.call.battery.GetBatteryInfo(), {'level': '50'}),
(self.call.battery.GetBatteryInfo(), {'level': '100'})):
self.battery.ChargeDeviceToLevel(95)
+ @mock.patch('time.sleep', mock.Mock())
+ def testChargeDeviceToLevel_failureSame(self):
+ with self.assertCalls(
+ (self.call.battery.SetCharging(True)),
+ (self.call.battery.GetBatteryInfo(), {'level': '50'}),
+ (self.call.battery.GetBatteryInfo(), {'level': '50'})):
+ with self.assertRaises(device_errors.DeviceChargingError):
+ old_max = battery_utils._MAX_CHARGE_ERROR
+ battery_utils._MAX_CHARGE_ERROR = 2
+ self.battery.ChargeDeviceToLevel(95)
+ battery_utils._MAX_CHARGE_ERROR = old_max
+
+ @mock.patch('time.sleep', mock.Mock())
+ def testChargeDeviceToLevel_failureDischarge(self):
+ with self.assertCalls(
+ (self.call.battery.SetCharging(True)),
+ (self.call.battery.GetBatteryInfo(), {'level': '50'}),
+ (self.call.battery.GetBatteryInfo(), {'level': '49'})):
+ with self.assertRaises(device_errors.DeviceChargingError):
+ old_max = battery_utils._MAX_CHARGE_ERROR
+ battery_utils._MAX_CHARGE_ERROR = 2
+ self.battery.ChargeDeviceToLevel(95)
+ battery_utils._MAX_CHARGE_ERROR = old_max
+
class BatteryUtilsDischargeDevice(BatteryUtilsTest):

Powered by Google App Engine
This is Rietveld 408576698