[Android] Detect if device is not charging properly.

build/android/provision_devices.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Provisions Android devices with settings required for bots.
 
 Usage:
   ./provision_devices.py [-d <device serial number>]
@@ skipping 114 matching lines @@
       logging.info("Version name for %s is %s", package, version_name)
 
     CheckExternalStorage(device)
 
   except device_errors.CommandTimeoutError:
     logging.exception('Timed out waiting for device %s. Adding to blacklist.',
                       str(device))
     if blacklist:
       blacklist.Extend([str(device)], reason='provision_timeout')
 
   except device_errors.CommandFailedError:

[jbudorick, 2016/02/05 01:40:43]

Not catching the exception below will result in the device getting blacklisted
here.

[rnephew (Reviews Here), 2016/02/05 01:52:00]

Acknowledged.

     logging.exception('Failed to provision device %s. Adding to blacklist.',
                       str(device))
     if blacklist:
       blacklist.Extend([str(device)], reason='provision_failure')
 
 def CheckExternalStorage(device):
   """Checks that storage is writable and if not makes it writable.
 
   Arguments:
     device: The device to check.
@@ skipping 185 matching lines @@
 
 def FinishProvisioning(device, options):
   # The lockscreen can't be disabled on user builds, so send a keyevent
   # to unlock it.
   if device.IsUserBuild():
     device.SendKeyEvent(keyevent.KEYCODE_MENU)
 
   if options.min_battery_level is not None:
     try:
       battery = battery_utils.BatteryUtils(device)
-      battery.ChargeDeviceToLevel(options.min_battery_level)
+      try:
+        battery.ChargeDeviceToLevel(options.min_battery_level)
+      except device_errors.DeviceChargingError:
+        device.Reboot()
+        try:
+          battery.ChargeDeviceToLevel(options.min_battery_level)
+        except device_errors.DeviceChargingError:

[jbudorick, 2016/02/05 01:40:43]

We shouldn't catch this or handle the blacklist here.

[rnephew (Reviews Here), 2016/02/05 01:52:00]

Done.

+          blacklist = device_blacklist.Blacklist(options.blacklist_file)
+          blacklist.Extend([str(device)], reason='Charging timeout')
+          logging.exception('Error while charging device.')
     except device_errors.CommandFailedError:

[jbudorick, 2016/02/05 01:40:43]

We shouldn't catch this either.

[rnephew (Reviews Here), 2016/02/05 01:52:00]

Done.

       logging.exception('Unable to charge device to specified level.')
 
   if options.max_battery_temp is not None:
     try:
       battery = battery_utils.BatteryUtils(device)
       battery.LetBatteryCoolToTemperature(options.max_battery_temp)
     except device_errors.CommandFailedError:
       logging.exception('Unable to let battery cool to specified temperature.')
 
   def _set_and_verify_date():
@@ skipping 177 matching lines @@
       },
     }
 
   devil_chromium.Initialize(custom_deps=devil_custom_deps)
 
   return ProvisionDevices(args)
 
 
 if __name__ == '__main__':
   sys.exit(main())