Issue 167253002: Revert of Count Promise constructor callings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 167253002: Revert of Count Promise constructor callings. (Closed)

Created:
6 years, 10 months ago by abarth-chromium

Modified:
6 years, 10 months ago

Reviewers:
haraken, tkent, yhirano

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Revert of Count Promise constructor callings. (https://codereview.chromium.org/166173002/) Reason for revert: This CL was landed with a "not lgtm". Original issue's description: > Count Promise constructor callings. > > Promise API is changing (See [1], [2] for details). > Count how Promise constructor functions are called. > > [1] https://mail.mozilla.org/pipermail/es-discuss/2014-January/035976.html > [2] https://mail.mozilla.org/pipermail/es-discuss/2014-February/036193.html > BUG=343815 > R=tkent, haraken > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167206 TBR=haraken@chromium.org,tkent@chromium.org,yhirano@chromium.org NOTREECHECKS=true NOTRY=true BUG=343815

Patch Set 1 #

Created: 6 years, 10 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -13 lines)			Patch
	M	Source/bindings/v8/custom/V8PromiseCustom.cpp	View		5 chunks	+0 lines, -9 lines	0 comments	Download
	M	Source/core/frame/UseCounter.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

Created Revert of Count Promise constructor callings.

6 years, 10 months ago (2014-02-14 17:50:20 UTC) #1

abarth-chromium

On 2014/02/14 17:50:58, abarth wrote: > The CQ bit was unchecked by mailto:abarth@chromium.org Oops!!! Sorry, ...

6 years, 10 months ago (2014-02-14 17:52:04 UTC) #3

abarth-chromium

6 years, 10 months ago (2014-02-14 17:52:05 UTC) #4

On 2014/02/14 17:50:58, abarth wrote:
> The CQ bit was unchecked by mailto:abarth@chromium.org

Oops!!!  Sorry, I see now that you changes the CL.

Expand Messages | Collapse Messages