Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1672513002: Expose packet loss counts from QUIC to NetworkQualityEstimator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed bengr comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 5f2f65bc9f4c309b10c54c899bc26158933387c5..2667a4db820b76e5cea1c757759213da39a987bc 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -31353,6 +31353,19 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="NQE.PacketLossRate" units="100 times">
+ <owner>bengr@chromium.org</owner>
+ <owner>tbansal@chromium.org</owner>
+ <summary>
+ Rough estimate of the packet loss rate multiplied by 100, before a
bengr 2016/02/19 00:45:09 Why is it rough?
tbansal1 2016/02/26 01:15:00 Done.
+ connectivity change is detected.
+
+ This metric is recorded when a connectivity change is detected. This will
bengr 2016/02/19 00:45:09 Is this per network session? I.e., my desktop Chro
tbansal1 2016/02/26 01:15:00 Changed it to record on every page load.
+ miss data from users whose connection type never changes and will be biased
+ to users whose connection type changes frequently.
+ </summary>
+</histogram>
+
<histogram name="NQE.PeakKbps" units="Kbps">
<owner>bengr@chromium.org</owner>
<owner>tbansal@chromium.org</owner>
@@ -86051,6 +86064,7 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="NQE.DifferenceRTTActualAndEstimated"/>
<affected-histogram name="NQE.DifferenceRTTEstimatedAndActual"/>
<affected-histogram name="NQE.FastestRTT"/>
+ <affected-histogram name="NQE.PacketLossRate"/>
<affected-histogram name="NQE.PeakKbps"/>
<affected-histogram name="NQE.RatioEstimatedToActualRTT"/>
<affected-histogram name="NQE.RTT.Percentile0"/>

Powered by Google App Engine
This is Rietveld 408576698