Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: net/base/socket_performance_watcher.h

Issue 1672513002: Expose packet loss counts from QUIC to NetworkQualityEstimator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed bengr comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/socket_performance_watcher.h
diff --git a/net/base/socket_performance_watcher.h b/net/base/socket_performance_watcher.h
index e0e76327ce63541e8d0dc2ba23215d34f953df41..3a7894612bcf3cd042823e8f77b4cdafcdb7362a 100644
--- a/net/base/socket_performance_watcher.h
+++ b/net/base/socket_performance_watcher.h
@@ -5,6 +5,8 @@
#ifndef NET_BASE_SOCKET_PERFORMANCE_WATCHER_H_
#define NET_BASE_SOCKET_PERFORMANCE_WATCHER_H_
+#include <stdint.h>
+
#include "base/macros.h"
#include "net/base/net_export.h"
#include "net/base/socket_performance_watcher_factory.h"
@@ -33,6 +35,18 @@ class NET_EXPORT_PRIVATE SocketPerformanceWatcher {
// made, hence no timestamp.
void OnUpdatedRTTAvailable(const base::TimeDelta& rtt) const;
+ // Called when an updated packet count at the transport layer is available.
+ // |num_packets_lost| is the number of packets lost.
bengr 2016/02/19 00:45:08 The parameter definitions are tautologies. Conside
tbansal1 2016/02/26 01:15:00 Done.
+ // |num_packets_received_in_order| is the number of packets received in
+ // order. |num_packets_received_not_in_order| is the number of packets
+ // received out of order. All the counts are since the last call to the
+ // OnUpdatedPacketCountAvailable. This method is called immediately after the
+ // observation is made, hence no timestamp.
+ void OnUpdatedPacketCountAvailable(
+ uint64_t num_packets_lost,
+ uint64_t num_packets_received_in_order,
+ uint64_t num_packets_received_not_in_order) const;
+
private:
// Transport layer protocol used by the socket that |this| is watching.
const SocketPerformanceWatcherFactory::Protocol protocol_;

Powered by Google App Engine
This is Rietveld 408576698