Expose packet loss counts from QUIC to NetworkQualityEstimator

net/base/socket_performance_watcher_factory.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_SOCKET_PERFORMANCE_WATCHER_FACTORY_H_
 #define NET_BASE_SOCKET_PERFORMANCE_WATCHER_FACTORY_H_
 
+#include <stdint.h>
+
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 #include "net/base/net_export.h"
 
 namespace base {
 class TimeDelta;
 }  // namespace base
 
 namespace net {
 
@@ skipping 17 matching lines @@
       const Protocol protocol) = 0;
 
   // Called when updated transport layer RTT information is available from one
   // of the watchers created by |this|. |protocol| is the protocol that was used
   // by the watcher. |rtt| must be the transport layer RTT from this device to
   // the remote transport layer endpoint. These methods are called immediately
   // after the observation is made, hence no timestamp.
   virtual void OnUpdatedRTTAvailable(const Protocol protocol,
                                      const base::TimeDelta& rtt) = 0;
 
+  // Called when an updated packet count at the transport layer is available.
+  // |protocol| is the protocol that was used by the watcher.
+  // |num_packets_lost| is the number of packets lost.
+  // |num_packets_received_in_order| is the number of packets received in
+  // order. |num_packets_received_not_in_order| is the number of packets
+  // received out of order. All the counts are since the last call to the
+  // OnUpdatedPacketCountAvailable. This method is called immediately after the
+  // observation is made, hence no timestamp.
+  //
+  // As an example, assume that the packets with sequence number 1, 2 and 5 have

[bengr, 2016/02/19 00:45:08]

I would be much more concise here. See my earlier comment on how to provide the
example.

[tbansal1, 2016/02/26 01:15:00]

Done.

+  // been received. Four cases are possible: (i) If next, a packet with sequence
+  // number 6 is received, then this function should be called with
+  // |num_packets_received_in_order| set to 1, and all other counts set to zero.
+  // (ii) If packet with sequence number 3 is received,
+  // |num_packets_received_not_in_order| should be set to 1, and all other
+  // counts
+  // should be zero.
+  // (iii) If packet with sequence number 2 is received again,
+  // |num_packets_received_not_in_order| should be set to 1, and all other
+  // counts
+  // should be zero.
+  // (iv) If packet with sequence number 10 is received,
+  // |num_packets_received_in_order| should be set to 1, |num_packets_lost|
+  // should be set to 4, and |num_packets_received_not_in_order| should be set
+  // to zero.
+  virtual void OnUpdatedPacketCountAvailable(
+      Protocol protocol,
+      uint64_t num_packets_lost,
+      uint64_t num_packets_received_in_order,
+      uint64_t num_packets_received_not_in_order) = 0;
+
  protected:
   SocketPerformanceWatcherFactory() {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(SocketPerformanceWatcherFactory);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_SOCKET_PERFORMANCE_WATCHER_FACTORY_H_