tools/metrics/histograms/histograms.xml - Issue 1672513002: Expose packet loss counts from QUIC to NetworkQualityEstimator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 1672513002: Expose packet loss counts from QUIC to NetworkQualityEstimator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed bengr comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index c523506ac08a8e3121b06dabe9ffa8b95b867cbe..f332c29c4b987c9bf2f30a4b4b3d24edbce2fa1c 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -31086,6 +31086,19 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="NQE.PacketLossRate" units="100 times">

+ <owner>bengr@chromium.org</owner>

+ <owner>tbansal@chromium.org</owner>

+ <summary>

+ Rough estimate of the packet loss rate multiplied by 100, before a

+ connectivity change is detected.

+ This metric is recorded when a connectivity change is detected. This will

+ miss data from users whose connection type never changes and will be biased

+ to users whose connection type changes frequently.

+ </summary>

+</histogram>

<owner>bengr@chromium.org</owner>

<owner>tbansal@chromium.org</owner>

@@ -85514,6 +85527,7 @@ To add a new entry, add it with any value and run test to compute valid value.

<affected-histogram name="NQE.DifferenceRTTActualAndEstimated"/>

<affected-histogram name="NQE.DifferenceRTTEstimatedAndActual"/>

<affected-histogram name="NQE.FastestRTT"/>

+ <affected-histogram name="NQE.PacketLossRate"/>

<affected-histogram name="NQE.PeakKbps"/>

<affected-histogram name="NQE.RatioEstimatedToActualRTT"/>

<affected-histogram name="NQE.RTT.Percentile0"/>

« net/base/network_quality_estimator.cc ('K') | « net/quic/quic_network_transaction_unittest.cc ('k') | no next file » | no next file with comments »